Edge worker maintenance state is remembered if worker crashes#50338
Merged
jscheffl merged 3 commits intoapache:mainfrom May 8, 2025
Merged
Edge worker maintenance state is remembered if worker crashes#50338jscheffl merged 3 commits intoapache:mainfrom
jscheffl merged 3 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:edge
jscheffl
added
kind:bug
jscheffl
reviewed
May 8, 2025
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py
Outdated
Show resolved
Hide resolved
jscheffl
approved these changes
May 8, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the fix! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the worker is in maintenance mode, and crashes, or shut down NOT gracefully, then the state will remain in MAINTENANCE_MODE and later will be set to UNKNOWN by the executor. So in the end it will not be in OFFLINE_MAINTENANCE, which means, that during startup it will start normally instead of maintenance.
So 2 loigcs were modified to prevent this:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.