Skip to content

[AIRFLOW-XXX] Pin Sendgrid dep.#5031

Merged
Fokko merged 1 commit intoapache:masterfrom
ashb:pin-sendgrid
Apr 3, 2019
Merged

[AIRFLOW-XXX] Pin Sendgrid dep.#5031
Fokko merged 1 commit intoapache:masterfrom
ashb:pin-sendgrid

Conversation

@ashb
Copy link
Copy Markdown
Member

@ashb ashb commented Apr 3, 2019 •
edited
Loading

Make sure you have checked all steps below.

Jira

  • No Jira

Description

  • Sendgrid just released 6.0 with breaking changes, and I don't have the
    time to define how to change our code or tests - as they haven't
    published a migration guide :(

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@ashb
[AIRFLOW-XXX] Pin Sendgrid dep.
e79ce58 
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
@ashb ashb requested review from Fokko, XD-DENG, feng-tao and kaxil and removed request for kaxil April 3, 2019 12:04
@ashb
Copy link
Copy Markdown
Member Author

ashb commented Apr 3, 2019

sorry to ping everyone - our tests are broken and I'd like to get 1.10.3rc1 started.

@XD-DENG
Copy link
Copy Markdown
Member

XD-DENG commented Apr 3, 2019

I can merge once CI passes

Fokko
Fokko approved these changes Apr 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadgrid

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 3, 2019

Codecov Report

Merging #5031 into master will increase coverage by 65.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #5031       +/-   ##
==========================================
+ Coverage   10.57%   76.1%   +65.52%     
==========================================
  Files         466     466               
  Lines       30088   30088               
==========================================
+ Hits         3181   22897    +19716     
+ Misses      26907    7191    -19716
Impacted Files Coverage Δ
airflow/plugins_manager.py 86.91% <0%> (+0.93%) ⬆️
airflow/executors/dask_executor.py 2% <0%> (+2%) ⬆️
airflow/exceptions.py 100% <0%> (+2.56%) ⬆️
airflow/config_templates/airflow_local_settings.py 76.47% <0%> (+2.94%) ⬆️
airflow/utils/operator_resources.py 86.95% <0%> (+4.34%) ⬆️
airflow/executors/__init__.py 63.46% <0%> (+5.76%) ⬆️
airflow/settings.py 84.25% <0%> (+11.81%) ⬆️
airflow/_vendor/nvd3/ipynb.py 14.28% <0%> (+14.28%) ⬆️
airflow/stats.py 69.69% <0%> (+16.66%) ⬆️
airflow/task/task_runner/__init__.py 63.63% <0%> (+18.18%) ⬆️
... and 365 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72ff0a...e79ce58. Read the comment docs.

@Fokko Fokko merged commit 2fcb761 into apache:master Apr 3, 2019
ashb added a commit that referenced this pull request Apr 3, 2019
@ashb
[AIRFLOW-XXX] Pin Sendgrid dep. (#5031)
c43a20f 
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
@ad-m ad-m mentioned this pull request Apr 4, 2019
Closed
@ashb ashb deleted the pin-sendgrid branch April 4, 2019 14:52
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
@ashb
[AIRFLOW-XXX] Pin Sendgrid dep. (apache#5031)
f559079 
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
@ashb @andriisoldatenko
[AIRFLOW-XXX] Pin Sendgrid dep. (apache#5031)
f5a9c93 
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
@ashb
[AIRFLOW-XXX] Pin Sendgrid dep. (apache#5031)
d18f4d5 
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@kaxil kaxil kaxil approved these changes

@XD-DENG XD-DENG XD-DENG approved these changes

@feng-tao feng-tao Awaiting requested review from feng-tao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashb @XD-DENG @codecov-io @Fokko @kaxil