Skip to content

[AIRFLOW-4223] Fix mypy issue in gcp speech_to_text and text_to_speech hooks and operators#5027

Merged
feng-tao merged 1 commit intoapache:masterfrom
feluelle:feature/AIRFLOW-4223-fix-mypy-gcp-text-speech
Apr 2, 2019
Merged

[AIRFLOW-4223] Fix mypy issue in gcp speech_to_text and text_to_speech hooks and operators#5027
feng-tao merged 1 commit intoapache:masterfrom
feluelle:feature/AIRFLOW-4223-fix-mypy-gcp-text-speech

Conversation

@feluelle
Copy link
Copy Markdown
Member

@feluelle feluelle commented Apr 2, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

  • fix mypy issue in gcp speech_to_text and text_to_speech hooks and operators

  • adds mock.ANY to compat.py

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

…h hooks and operators

- adds mock.ANY to compat.py
@XD-DENG
Copy link
Copy Markdown
Member

XD-DENG commented Apr 2, 2019

Seems there are transient errors in the K8S-related tests. Let me restart and see.

@XD-DENG
Copy link
Copy Markdown
Member

XD-DENG commented Apr 2, 2019

The two K8S tests failed again after my restarting.

@feng-tao
Copy link
Copy Markdown
Member

feng-tao commented Apr 2, 2019

restart the CI

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@4a2c9c5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5027   +/-   ##
=========================================
  Coverage          ?   75.98%           
=========================================
  Files             ?      466           
  Lines             ?    30066           
  Branches          ?        0           
=========================================
  Hits              ?    22846           
  Misses            ?     7220           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2c9c5...06c9003. Read the comment docs.

@feng-tao
Copy link
Copy Markdown
Member

feng-tao commented Apr 2, 2019

thanks @feluelle

@feng-tao feng-tao merged commit 36ff0d0 into apache:master Apr 2, 2019
@feluelle feluelle deleted the feature/AIRFLOW-4223-fix-mypy-gcp-text-speech branch April 9, 2019 12:12
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
…h hooks and operators (apache#5027)

- adds mock.ANY to compat.py
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…h hooks and operators (apache#5027)

- adds mock.ANY to compat.py
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
…h hooks and operators (apache#5027)

- adds mock.ANY to compat.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants