Move access_denied_message webserver config to fab by pierrejeambrun · Pull Request #50208 · apache/airflow

pierrejeambrun · 2025-05-05T15:04:07Z

Part of: #49896

This is still needed by the fab provider. Just confirming how things articulate between the provider / core dependency (provider requirements) on a minimal example, before moving on with other webserver config params.

providers/fab/provider.yaml

airflow-core/src/airflow/configuration.py

kaxil · 2025-05-06T16:01:57Z

Changing the milestone to 3.0.2 -- about to cut 3.0.1

jscheffl

This code changes provider and core at the same time. How if somebody uses the old core and a new FAB? Are you sure it is not breaking?

vincbeck · 2025-05-12T12:33:15Z

This code changes provider and core at the same time. How if somebody uses the old core and a new FAB? Are you sure it is not breaking?

I think Jens is right, but on the other side: if you use Airflow 3.0.2 (next version of Airflow not yet released that includes this change) and FAB 2.0.2 (version of FAB provider already released, NOT containing this change), then conf.get("webserver", "access_denied_message") will fail.

We already have in pyproject.toml:

"fab" = [
    "apache-airflow-providers-fab>=2.0.2" # Set from MIN_VERSION_OVERRIDE in update_airflow_pyproject_toml.py
]

Should we bump it up to 2.0.3 when the new version of FAB is released? It will have to be done as follow-up obviously.

potiuk · 2025-05-12T21:56:40Z

Should we bump it up to 2.0.3 when the new version of FAB is released? It will have to be done as follow-up obviously.

If we really want to set min version of FAB then no - we do not have to wait- we can add >2.0.3 AND update fab provider in the same PR to be 2.0.3 . This should all work

pierrejeambrun · 2025-05-13T08:48:11Z

Thanks for the review guys.

I have updated dependencies:

the fab provider version to 2.0.3. And in fab provider, airflow core dependency is now >=3.0.2
in airflow core the fab provider dependency is now >=2.0.3.

This way basically fab 2.0.3 and core 3.0.2 can only work together. (or more recent).

Also updated to core 3.0.2 the deprecated_options

* bump Airflow to 3.0.1 * remove common.messaging from the list of removed providers * add fab to the list of removed providers in anticipation of the apache#50208

potiuk · 2025-05-13T12:11:34Z

The compat tests shoudl be fixed after we merge #50537

providers/fab/pyproject.toml

* bump Airflow to 3.0.1 * remove common.messaging from the list of removed providers * add fab to the list of removed providers in anticipation of the #50208

pierrejeambrun · 2025-05-13T13:29:42Z

#50537 has been merged, rebasing

github-actions · 2025-05-13T14:41:30Z

Backport failed to create: v3-0-test. View the failure log Run details

Status	Branch	Result
❌	v3-0-test

You can attempt to backport this manually by running:

cherry_picker a18a1df v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

* Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI (cherry picked from commit a18a1df)

pierrejeambrun · 2025-05-13T15:01:48Z

Cherry picking PR here #50544

* Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI (cherry picked from commit a18a1df)

… (#50544) * Move access_denied_message webserver config to fab (#50208) * Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI (cherry picked from commit a18a1df) * Fix CI * docs: conditionally render section‐move links in sections‐and‐options include (#50582) * Add condition for section move in docs * docs(fab): add Sphinx anchors for access_denied_message and expose_hostname config options (cherry picked from commit 39f215f) --------- Co-authored-by: Ankit Chaurasia <[email protected]>

…e#50537) * bump Airflow to 3.0.1 * remove common.messaging from the list of removed providers * add fab to the list of removed providers in anticipation of the apache#50208

* Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI

pierrejeambrun self-assigned this May 5, 2025

pierrejeambrun requested review from ashb, gopidesupavan, potiuk and vincbeck as code owners May 5, 2025 15:04

boring-cyborg bot added area:CLI area:ConfigTemplates area:dev-tools area:providers provider:fab labels May 5, 2025

pierrejeambrun added this to the Airflow 3.0.1 milestone May 5, 2025

pierrejeambrun commented May 5, 2025

View reviewed changes

providers/fab/provider.yaml Outdated Show resolved Hide resolved

pierrejeambrun force-pushed the move-access_denied_message-webserver-config branch from 2df9a68 to 34530a7 Compare May 5, 2025 15:06

pierrejeambrun mentioned this pull request May 5, 2025

Clean redundant Webserver configs #49896

Closed

pierrejeambrun force-pushed the move-access_denied_message-webserver-config branch from 34530a7 to e5e91ac Compare May 5, 2025 15:25

pierrejeambrun commented May 5, 2025

View reviewed changes

airflow-core/src/airflow/configuration.py Outdated Show resolved Hide resolved

kaxil modified the milestones: Airflow 3.0.1, Airflow 3.0.2 May 6, 2025

pierrejeambrun force-pushed the move-access_denied_message-webserver-config branch from d491f5e to 81ffc76 Compare May 6, 2025 16:36

jscheffl approved these changes May 11, 2025

View reviewed changes

pierrejeambrun mentioned this pull request May 13, 2025

Move webserver expose_hostname config to fab #50269

Merged

pierrejeambrun requested review from amoghrajesh and jedcunningham as code owners May 13, 2025 11:38

potiuk mentioned this pull request May 13, 2025

Update compatibility setup for Airflow 3.0 compatibility tests #50537

Merged

amoghrajesh approved these changes May 13, 2025

View reviewed changes

vincbeck reviewed May 13, 2025

View reviewed changes

providers/fab/pyproject.toml Show resolved Hide resolved

pierrejeambrun added 6 commits May 13, 2025 15:29

Move access_denied_message webserver config to fab

b161c76

Fix CI

e94abed

Update to fab 2.0.3

70fc6ae

Change core to 3.0.2

4acb50d

fab depends on apache-airflow 3.0.2

d26ea08

Fix CI

5f094b5

pierrejeambrun force-pushed the move-access_denied_message-webserver-config branch from f2b9486 to 5f094b5 Compare May 13, 2025 13:29

vincbeck approved these changes May 13, 2025

View reviewed changes

pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 13, 2025

pierrejeambrun merged commit a18a1df into apache:main May 13, 2025
96 checks passed

pierrejeambrun deleted the move-access_denied_message-webserver-config branch May 13, 2025 14:40

pierrejeambrun mentioned this pull request May 13, 2025

[v3-0-test] Move access_denied_message webserver config to fab (#50208) #50544

Merged

sunank200 mentioned this pull request May 14, 2025

docs: conditionally render section‐move links in sections‐and‐options include #50582

Merged

eladkal mentioned this pull request May 14, 2025

Status of testing Providers that were prepared on May 14, 2025 #50599

Closed

pierrejeambrun mentioned this pull request May 21, 2025

Move secret_key config to api section #50839

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move access_denied_message webserver config to fab#50208

Move access_denied_message webserver config to fab#50208
pierrejeambrun merged 6 commits intoapache:mainfrom
astronomer:move-access_denied_message-webserver-config

pierrejeambrun commented May 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kaxil commented May 6, 2025

Uh oh!

jscheffl left a comment

Uh oh!

vincbeck commented May 12, 2025

Uh oh!

potiuk commented May 12, 2025

Uh oh!

pierrejeambrun commented May 13, 2025 •

edited

Loading

Uh oh!

potiuk commented May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

pierrejeambrun commented May 13, 2025

Uh oh!

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

pierrejeambrun commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

pierrejeambrun commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaxil commented May 6, 2025

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

vincbeck commented May 12, 2025

Uh oh!

potiuk commented May 12, 2025

Uh oh!

pierrejeambrun commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potiuk commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun commented May 13, 2025

Uh oh!

Uh oh!

github-actions bot commented May 13, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Uh oh!

pierrejeambrun commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pierrejeambrun commented May 5, 2025 •

edited

Loading

pierrejeambrun commented May 13, 2025 •

edited

Loading

potiuk commented May 13, 2025 •

edited

Loading