Remove special case for building PROD image in non-main branch#50115
Merged
potiuk merged 1 commit intoapache:mainfrom May 2, 2025
Merged
Remove special case for building PROD image in non-main branch#50115potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
force-pushed
the
remove-special-case-for-prod-image-builds
branch
from
8dd8633 to
8465d7b
Compare
When we removed "chicken-egg-providers" from the build in apache#49799 we should be able now to build PROD image in v3*test branch without special case of only using PyPI providers. This should work because in v3-*test branch we automatically detect (by presence of relesed tag) whether we should build provider from sources or use it from PyPI. In normal circumstances, we would need use providers fro PyPI, but sometimes (For example for 3.0.1) we need to use some providers from sources before they get released (for example common.messaging 1.0.1 that is the lowest possible common.messaging for Airflow 3.0.1. This PR removes that special case and switches to the same method of building PROD image in main and in release branch.
potiuk
force-pushed
the
remove-special-case-for-prod-image-builds
branch
from
8465d7b to
08bd275
Compare
potiuk
added
the
backport-to-v3-1-test
Member
Author
|
Need that one to backport common.messaging to |
potiuk
commented
May 2, 2025
eladkal
approved these changes
May 2, 2025
gopidesupavan
approved these changes
May 2, 2025
kaxil
approved these changes
May 2, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 9deb2a7 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 2, 2025
…ranch (apache#50115) When we removed "chicken-egg-providers" from the build in apache#49799 we should be able now to build PROD image in v3*test branch without special case of only using PyPI providers. This should work because in v3-*test branch we automatically detect (by presence of relesed tag) whether we should build provider from sources or use it from PyPI. In normal circumstances, we would need use providers fro PyPI, but sometimes (For example for 3.0.1) we need to use some providers from sources before they get released (for example common.messaging 1.0.1 that is the lowest possible common.messaging for Airflow 3.0.1. This PR removes that special case and switches to the same method of building PROD image in main and in release branch. (cherry picked from commit 9deb2a7) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
that referenced
this pull request
May 2, 2025
…ranch (#50115) (#50118) When we removed "chicken-egg-providers" from the build in #49799 we should be able now to build PROD image in v3*test branch without special case of only using PyPI providers. This should work because in v3-*test branch we automatically detect (by presence of relesed tag) whether we should build provider from sources or use it from PyPI. In normal circumstances, we would need use providers fro PyPI, but sometimes (For example for 3.0.1) we need to use some providers from sources before they get released (for example common.messaging 1.0.1 that is the lowest possible common.messaging for Airflow 3.0.1. This PR removes that special case and switches to the same method of building PROD image in main and in release branch. (cherry picked from commit 9deb2a7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we removed "chicken-egg-providers" from the build in #49799 we should be able now to build PROD image in v3*test branch without special case of only using PyPI providers. This should work because in v3-*test branch we automatically detect (by presence of relesed tag) whether we should build provider from sources or use it from PyPI. In normal circumstances, we would need use providers fro PyPI, but sometimes (For example for 3.0.1) we need to use some providers from sources before they get released (for example common.messaging 1.0.1 that is the lowest possible common.messaging for Airflow 3.0.1.
This PR removes that special case and switches to the same method of building PROD image in main and in release branch.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.