[v3-0-test] Move SQS message queue to Amazon provider (#50057)#50096
Merged
potiuk merged 1 commit intoapache:v3-0-testfrom May 2, 2025
Merged
[v3-0-test] Move SQS message queue to Amazon provider (#50057)#50096potiuk merged 1 commit intoapache:v3-0-testfrom
potiuk merged 1 commit intoapache:v3-0-testfrom
Conversation
potiuk
requested review from
ashb,
eladkal,
gopidesupavan,
hussein-awala,
jedcunningham,
o-nikolas and
vincbeck
as code owners
boring-cyborg
bot
added
area:CLI
area:providers
kind:documentation
provider:amazon
potiuk
force-pushed
the
backport-4f962f4-v3-0-test
branch
from
703b3c0 to
463a18f
Compare
vincbeck
approved these changes
May 1, 2025
potiuk
added
the
full tests needed
potiuk
force-pushed
the
backport-4f962f4-v3-0-test
branch
from
463a18f to
47b9ca1
Compare
hussein-awala
approved these changes
May 1, 2025
potiuk
force-pushed
the
backport-4f962f4-v3-0-test
branch
from
47b9ca1 to
9452e96
Compare
Member
Author
|
Will need #50115 cherry-picked to succeed building PROD images (we need to build common.messaging 1.0.1 built locally until we release it in PyPI |
potiuk
force-pushed
the
backport-4f962f4-v3-0-test
branch
from
9452e96 to
558d57b
Compare
The common.messaging abstraction should discover common messaging queue providers using the same mechanism as we have for other core extensions. Previously common.messaging had the optional (but not really) dependencies to other providers, but that was not needed and introduced unnecessary coupling. By switching to our built-in discovery mechanism we get immediately all the niceties of provider discovery mechanisms: * queue is provided by the actual provider where the service or integration already is implemented (sqs -> amazon provider, in the future kafka -> kafka provider) * queues are discovered from installed providers * there is no coupling or imports between common.messaging and the providers that implement messaging, the dependency is in the other way - providers that implement messaging depend on common.messaging * airflow providers queues CLI and providers core extensions documentation is automatically generated (cherry picked from commit 4f962f4) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
force-pushed
the
backport-4f962f4-v3-0-test
branch
from
558d57b to
c23d882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common.messaging abstraction should discover common messaging queue providers using the same mechanism as we have for other core extensions. Previously common.messaging had the optional (but not really) dependencies to other providers, but that was not needed and introduced unnecessary coupling.
By switching to our built-in discovery mechanism we get immediately all the niceties of provider discovery mechanisms:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.