Add back ProxyFix Middleware for flask app builder#49942
Merged
vincbeck merged 6 commits intoapache:mainfrom Apr 30, 2025
Merged
Add back ProxyFix Middleware for flask app builder#49942vincbeck merged 6 commits intoapache:mainfrom
vincbeck merged 6 commits intoapache:mainfrom
Conversation
Fixes Issues apache#49781 apache#49705 Add back the Removed ProxyFix Middleware to allow Oauth2 authentication when using a reverse proxy like nginx or traefik. When not using proxyFix the redirect_url incorectly gets set to http:// instead of the expected https://, This breaks many authentication flows, especially azure, which does not allow http:// redirect_urls for anything other than localhost. Help is needed with adjusting the configuration from webserver to api-server.
gschuurman
force-pushed
the
feature/proxy_fix
branch
from
b0d3040 to
5fb1acd
Compare
vincbeck
reviewed
Apr 29, 2025
providers/fab/src/airflow/providers/fab/www/extensions/init_wsgi_middlewares.py
Outdated
Show resolved
Hide resolved
Add the original proxy_fix documentation back into the FAB provider package and update the section to match fab instead of websever.
eladkal
reviewed
Apr 29, 2025
gschuurman
force-pushed
the
feature/proxy_fix
branch
from
6114d45 to
aff64c6
Compare
vincbeck
approved these changes
Apr 29, 2025
|
This does not seem to be in a release yet. Since I'm currently running into this problem, I would be interested in the current state of this |
Contributor
|
This has definitely been released. If you experience an issue can you please create an issue and describe the bug you are experiencing |
Yep sorry, false alarm. Found out that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #49781
Fixes: #49705
Add back the Removed ProxyFix Middleware to allow Oauth2 authentication when using a reverse proxy like nginx or traefik.
When not using proxyFix the redirect_url incorectly gets set to http:// instead of the expected https://, This breaks many authentication flows, especially azure, which does not allow http:// redirect_urls for anything other than localhost.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.