Fix execution API server URL handling for relative paths#49782
Merged
kaxil merged 1 commit intoapache:mainfrom Apr 25, 2025
Merged
Fix execution API server URL handling for relative paths#49782kaxil merged 1 commit intoapache:mainfrom
kaxil merged 1 commit intoapache:mainfrom
Conversation
kaxil
requested review from
XD-DENG,
ashb,
gopidesupavan,
hussein-awala,
jedcunningham,
jscheffl,
o-nikolas,
pierrejeambrun and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
area:Executors-core
kaxil
force-pushed
the
fix-bug-execution-api
branch
2 times, most recently
from
c2e3499 to
66f8ac7
Compare
potiuk
reviewed
Apr 25, 2025
gopidesupavan
approved these changes
Apr 25, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
force-pushed
the
fix-bug-execution-api
branch
from
66f8ac7 to
4de9c40
Compare
kaxil
added a commit
that referenced
this pull request
Apr 25, 2025
Follow-up of #49747 which broke some workflows including `breeze start-airflow`, requiring #49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in #49753) that occurred when base_url was a relative path without protocol. (cherry picked from commit 3b9ae48)
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 28, 2025
Follow-up of apache#49782 but for KubernetesExecutor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #49747 which broke some workflows including
breeze start-airflow, requiring #49753.When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either
base_urlorexecution_api_server_urlconfiguration.Fixes
httpx.UnsupportedProtocolerror (as seen in #49753) that occurred when base_url was a relative path without protocol.Same as last PR, the code is duplicated intentionally to not need coupling between Provider and new version of core Airflow
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.