Set execution api url in breeze config environment#49753
Merged
gopidesupavan merged 2 commits intoapache:mainfrom Apr 24, 2025
Merged
Set execution api url in breeze config environment#49753gopidesupavan merged 2 commits intoapache:mainfrom
gopidesupavan merged 2 commits intoapache:mainfrom
Conversation
Member
Author
|
I think the default url is removed? |
jscheffl
approved these changes
Apr 24, 2025
jscheffl
reviewed
Apr 24, 2025
jscheffl
approved these changes
Apr 24, 2025
Member
|
nice |
ashb
reviewed
Apr 25, 2025
| _set_var(_env, "AIRFLOW__CELERY__BROKER_URL", self.airflow_celery_broker_url) | ||
| _set_var(_env, "AIRFLOW__CORE__AUTH_MANAGER", self.auth_manager_path) | ||
| _set_var(_env, "AIRFLOW__CORE__EXECUTOR", self.executor) | ||
| _set_var(_env, "AIRFLOW__CORE__EXECUTION_API_SERVER_URL", "http://localhost:8080/execution/") |
Member
There was a problem hiding this comment.
Why did we need to set this? This is the default
Member
Author
There was a problem hiding this comment.
The default is removed #49747 , and the default base_url doesn't have any value in https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/config_templates/config.yml#L1294 ?
Member
Author
There was a problem hiding this comment.
Can we update default base_url with value?
Member
There was a problem hiding this comment.
No -- if we set base_url then all sorts of things with the webserver get trickier -- we removed it from there for a reason.
@kaxil Perhaps we need to tweak 49747 to use base_url if it's an absolute URL, but default to localhost:8080 if it's relative?
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
* Set execution api url in breeze config environment * Set execution api url from breeze shell params
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
that referenced
this pull request
Apr 25, 2025
Follow-up of #49747 which broke some workflows including `breeze start-airflow`, requiring #49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in #49753) that occurred when base_url was a relative path without protocol.
kaxil
added a commit
that referenced
this pull request
Apr 25, 2025
Follow-up of #49747 which broke some workflows including `breeze start-airflow`, requiring #49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in #49753) that occurred when base_url was a relative path without protocol. (cherry picked from commit 3b9ae48)
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
* Set execution api url in breeze config environment * Set execution api url from breeze shell params
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
Follow-up of apache#49747 which broke some workflows including `breeze start-airflow`, requiring apache#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache#49753) that occurred when base_url was a relative path without protocol.
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 25, 2025
Follow-up of apache/airflow#49747 which broke some workflows including `breeze start-airflow`, requiring apache/airflow#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache/airflow#49753) that occurred when base_url was a relative path without protocol. (cherry picked from commit 3b9ae489a56cde7fe1cd663d7da88fabb831c664) GitOrigin-RevId: 3eeb2533a425dd25ffeebd5e71306f048a12f38c
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 22, 2025
Follow-up of apache/airflow#49747 which broke some workflows including `breeze start-airflow`, requiring apache/airflow#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache/airflow#49753) that occurred when base_url was a relative path without protocol. GitOrigin-RevId: 3b9ae489a56cde7fe1cd663d7da88fabb831c664
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 28, 2026
Follow-up of apache/airflow#49747 which broke some workflows including `breeze start-airflow`, requiring apache/airflow#49753. When base_url is a relative path (starts with '/'), default to using http://localhost:8080 as the base URL. This maintains backward compatibility with the previous default behavior while still allowing custom absolute URLs through either `base_url` or `execution_api_server_url` configuration. Fixes `httpx.UnsupportedProtocol` error (as seen in apache/airflow#49753) that occurred when base_url was a relative path without protocol. GitOrigin-RevId: 3b9ae489a56cde7fe1cd663d7da88fabb831c664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.