Skip to content

Ensure fab provider is installed when running EdgeExecutor#49473

Merged
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:bugfix/add-fab-dependency-to-edge3
Apr 20, 2025
Merged

Ensure fab provider is installed when running EdgeExecutor#49473
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:bugfix/add-fab-dependency-to-edge3

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Apr 20, 2025

I noticed that FAB dependency is missing in edge3 package. The FastAPI/Connexion API needs FAB to be working (authentication of API requests from remote). This might be un-tangled in future as cleanup and FAB does not need to be used... so as a fix until cleaned this adds the missing install dependency.

Exception seen in the logs when starting w/o FAB installed:

[2025-04-20T09:56:50.115+0000] {plugins_manager.py:262} ERROR - Failed to import plugin edge_executor
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/airflow/plugins_manager.py", line 254, in load_entrypoint_plugins
    plugin_class = entry_point.load()
                   ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/importlib/metadata/__init__.py", line 205, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/usr/local/lib/python3.12/site-packages/airflow/providers/edge3/plugins/edge_executor_plugin.py", line 39, in <module>
    from airflow.providers.fab.www.auth import has_access_view
ModuleNotFoundError: No module named 'airflow.providers.fab'

@boring-cyborg boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Apr 20, 2025
@jscheffl jscheffl requested review from eladkal, kaxil and potiuk April 20, 2025 09:54
@jscheffl jscheffl merged commit d01052e into apache:main Apr 20, 2025
52 checks passed
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
@jscheffl jscheffl deleted the bugfix/add-fab-dependency-to-edge3 branch October 5, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants