[AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs#4939
Merged
Fokko merged 12 commits intoapache:masterfrom Mar 29, 2019
cooltoast:master
Merged
[AIRFLOW-4120] Modify SchedulerJob.manage_slas to respect zero timedelta SLAs#4939Fokko merged 12 commits intoapache:masterfrom cooltoast:master
Fokko merged 12 commits intoapache:masterfrom
cooltoast:master
Conversation
Contributor
Author
|
Weird that some of the tests failed in the pull request build, but I can't seem to restart the build. The build succeeds on my branch. |
Codecov Report
@@ Coverage Diff @@
## master #4939 +/- ##
========================================
+ Coverage 75.59% 75.8% +0.2%
========================================
Files 454 458 +4
Lines 29197 29862 +665
========================================
+ Hits 22071 22636 +565
- Misses 7126 7226 +100
Continue to review full report at Codecov.
|
Contributor
|
@cooltoast would it be possible to provide a test? |
Contributor
Author
|
@Fokko I added a couple tests, please take a look. thank you |
mik-laj
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Mar 29, 2019
…lta SLAs (apache#4939) Modify SchedulerJob.manage_slas to respect zero timedelta SLAs
ashb
pushed a commit
that referenced
this pull request
Apr 6, 2019
…lta SLAs (#4939) Modify SchedulerJob.manage_slas to respect zero timedelta SLAs
cthenderson
pushed a commit
to cthenderson/apache-airflow
that referenced
this pull request
Apr 16, 2019
…lta SLAs (apache#4939) Modify SchedulerJob.manage_slas to respect zero timedelta SLAs
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
…lta SLAs (apache#4939) Modify SchedulerJob.manage_slas to respect zero timedelta SLAs
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…lta SLAs (apache#4939) Modify SchedulerJob.manage_slas to respect zero timedelta SLAs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Description
Added a simple
isinstancecheck inside themanage_slasmethod ofSchedulerJob, so we can differentiate between falsy values ofslaand validtimedeltavalues like:timedelta()andtimedelta(0).Code Quality
flake8