Make git connection optional for git dag bundle#49270
Conversation
ephraimbuddy
left a comment
ephraimbuddy
left a comment
There was a problem hiding this comment.
Instead of making GitDagBundle not to require a connection, how about creating an entire class that people can use if they don't want to use connection? We can rename GitDagBundle to reflect that it requires a connection and name the new bundle to reflect that it doesn't need it. This will make GitDagBundle consistent with how we design operators or anything that needs a connection by keeping a default connection ID
|
I'm not too familiar with the bundle backends, but having a separate class seems like an odd UX decision. One of the reasons for wanting to make it optional is so that you can either:
In some ways it's similar to the AWS Hook, where if you don't configure it it will try and use instance identity out of the box, or what ever other configs it can find on the host. Which is also how |
dstandish
force-pushed
the
make-it-optional-to-use-git-conn-for-git-bundle
branch
from
ef9d0b2 to
0535232
Compare
This started failing after apache#49270 was merged
This started failing after #49270 was merged
This started failing after apache/airflow#49270 was merged GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
This started failing after apache/airflow#49270 was merged GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
This started failing after apache/airflow#49270 was merged GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
This started failing after apache/airflow#49270 was merged GitOrigin-RevId: 32b3f7cee6d3f3945b215b070c82341b31341c04
6 participants
Make it so we don't need to define a git connection for a git dag bundle.