[AIRFLOW-4034] Make string formatting explicit by removing **locals()#4861
Merged
Fokko merged 1 commit intoapache:masterfrom Apr 2, 2019
BasPH:bash-remove-locals-globals
Merged
[AIRFLOW-4034] Make string formatting explicit by removing **locals()#4861Fokko merged 1 commit intoapache:masterfrom BasPH:bash-remove-locals-globals
Fokko merged 1 commit intoapache:masterfrom
BasPH:bash-remove-locals-globals
Conversation
BasPH
changed the title
ashb
reviewed
Mar 7, 2019
Fokko
approved these changes
Mar 17, 2019
Contributor
|
Sad CI: |
Contributor
Author
|
Those errors seem unrelated? Shall I trigger another build? |
Contributor
Author
|
Done a re-run. No luck... Will try to find some time later this week. |
Contributor
|
Ok, let me know! 👍 |
**locals() is used a lot for string formatting. This is considered bad programming practice.
Contributor
Author
|
@Fokko I found a bug and fixed it (the |
Contributor
|
Restarted the job! Let's see. |
Codecov Report
@@ Coverage Diff @@
## master #4861 +/- ##
==========================================
+ Coverage 75.76% 75.76% +<.01%
==========================================
Files 461 461
Lines 29955 29949 -6
==========================================
- Hits 22694 22691 -3
+ Misses 7261 7258 -3
Continue to review full report at Codecov.
|
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2019
…4861) **locals() is used a lot for string formatting. This is considered bad programming practice.
cthenderson
pushed a commit
to cthenderson/apache-airflow
that referenced
this pull request
Apr 16, 2019
…pache#4861) **locals() is used a lot for string formatting. This is considered bad programming practice.
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
…pache#4861) **locals() is used a lot for string formatting. This is considered bad programming practice.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…pache#4861) **locals() is used a lot for string formatting. This is considered bad programming practice.
dharamsk
pushed a commit
to postmates/airflow
that referenced
this pull request
Aug 8, 2019
…pache#4861) **locals() is used a lot for string formatting. This is considered bad programming practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
I've replaced all
"...{var}...".format(**locals())by:"...{var}...".format(var=var)if string"...%s...", myvarif used in loggingbecause it is explicit what variables are used in the string formatting.
Tests
Commits
Documentation
Code Quality
flake8