Description

The logger was used incorrectly in several places. We should not format the text before passing it to the logger, because it can be ignored in the logger.

Hi @mik-laj , does logger ignore format method? In which cases?

The logger does know str.format() but it's best practice in Python to use this form with logging: logger.info("Hello %s", "world") since that creates a string only when it actually gets logged. str.format() and f-strings create strings before they get passed to the logger, even if the string is never logged. So it's considered inefficient and not advised.

@mik-laj Nice work! Also got rid of some of the **locals()👍.

If parameters and text are pass separately, they can also be independently analyzed if more advanced loggers are used.

I can not find any more problems. Can I ask you to review and accept changes?

I updated a PR with all suggestion.

Thanks @mik-laj

Unfortunately the CI is sad now:

======================================================================
33) FAIL: test_exception_propagation (tests.executors.test_celery_executor.CeleryExecutorTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/executors/test_celery_executor.py line 162 in test_exception_propagation
      self.assertIn('AttributeError', args[1])
   AssertionError: 'AttributeError' not found in AttributeError("'dict' object has no attribute 'state'",)

Codecov Report

Merging #4804 into master will increase coverage by <.01%.
The diff coverage is 71.53%.

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
+ Coverage   75.28%   75.29%   +<.01%     
==========================================
  Files         450      450              
  Lines       29026    29019       -7     
==========================================
- Hits        21852    21849       -3     
+ Misses       7174     7170       -4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8dacae...c415804. Read the comment docs.

@Fokko Now Travis is green.

Thanks @mik-laj