Fix scheduler crash due to comparing Nullable value in query#47301
Merged
ephraimbuddy merged 1 commit intoMar 3, 2025
Merged
Conversation
Before using < for DR.logical_date in query, first check if logical_date is not null.
eladkal
reviewed
Mar 3, 2025
pierrejeambrun
approved these changes
Mar 3, 2025
eladkal
approved these changes
Mar 3, 2025
Member
|
@ephraimbuddy This fixes the crash, but is the behaviour in the scheduler correct? |
Contributor
Author
I didn't check but now that I checked it's no longer working as expected and it's also confusing how it should work. I ran a task that raised an exception, triggered a new run, and it started and failed. I used logical date for consecutive runs but didn't feel the depends_on_past feature. It's also confusing how this should work now. Should it work for only runs with logical date or for every run... |
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
…47301) Before using < for DR.logical_date in query, first check if logical_date is not null.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…47301) Before using < for DR.logical_date in query, first check if logical_date is not null.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before using < for DR.logical_date in query, check if logical_date is not null.
closes: #47296