AIP-72: Supporting Pulling multiple XCOM values#45509
Merged
kaxil merged 2 commits intoapache:mainfrom Jan 10, 2025
Merged
Conversation
Contributor
Author
|
Not too sure where to add the tests for this. |
ashb
reviewed
Jan 9, 2025
ashb
reviewed
Jan 9, 2025
ashb
reviewed
Jan 9, 2025
Member
ashb
left a comment
There was a problem hiding this comment.
How/where to test: add some tests that create a RunteimTaskInstance method and call the functions on it.
kaxil
reviewed
Jan 9, 2025
kaxil
reviewed
Jan 9, 2025
kaxil
reviewed
Jan 9, 2025
kaxil
reviewed
Jan 9, 2025
kaxil
reviewed
Jan 9, 2025
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 9, 2025
This test was missed and will help apache#45509
kaxil
added a commit
that referenced
this pull request
Jan 9, 2025
Apply suggestions from code review cleanup and adding tests Co-Authored-By: Kaxil Naik <[email protected]>
b589847 to
e958a5d
Compare
kaxil
approved these changes
Jan 9, 2025
Member
kaxil
left a comment
There was a problem hiding this comment.
Approving, but you should take a look too :D since I added the test -- to verify that you are happy with it.
Member
|
@amoghrajesh I merged this to tick off items :) -- but feel free to change anything in follow-up |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
This test was missed and will help apache#45509
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
This test was missed and will help apache#45509
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
amoghrajesh
commented
Jan 20, 2025
Contributor
Author
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks @kaxil.
Yes it looks good.
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This test was missed and will help apache#45509
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 28, 2025
This test was missed and will help apache/airflow#45509 GitOrigin-RevId: 5b523dac778c8eb5abad9c912f7ebaf08abdbe0b
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
This test was missed and will help apache/airflow#45509 GitOrigin-RevId: 5b523dac778c8eb5abad9c912f7ebaf08abdbe0b
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
This test was missed and will help apache/airflow#45509 GitOrigin-RevId: 5b523dac778c8eb5abad9c912f7ebaf08abdbe0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #45243
We can just handle xcoms for multiple task ids in the client directly by reusing the same task runner machinery.
DAG:
Task1:

Task2:

Task3: (gets xcoms pushed by 1 and 2)

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.