Update conf column in dag_run table type from bytes to JSON#44533
Merged
ephraimbuddy merged 56 commits intoapache:mainfrom Jan 13, 2025
Merged
Update conf column in dag_run table type from bytes to JSON#44533ephraimbuddy merged 56 commits intoapache:mainfrom
ephraimbuddy merged 56 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:db-migrations
Contributor
Author
|
While Testing this I noticed an issue in the downgrade case. We are not removing the data from downgrade and just perform below conversion. I am getting Should we also move data to the archive table in case of a downgrade as well? |
Member
Yeah, it is different than XCom, because XCom code had handling of both JSON & pickle type -- for dagrun conf it would be different. For downgrade you might just want to insert all records from the archive table back here. |
kaxil
reviewed
Dec 2, 2024
…rate_conf_column_as_json
vatsrahul1001
added
the
airflow3.0:breaking
vatsrahul1001
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
…onomer/airflow into dag_run_migrate_conf_column_as_json
kaxil
reviewed
Dec 3, 2024
airflow/migrations/versions/0050_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
kaxil
pushed a commit
that referenced
this pull request
Dec 3, 2024
In [PR](#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](#44533 (comment)). related: #44166
airflow/migrations/versions/0050_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0050_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0050_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
reviewed
Jan 7, 2025
airflow/migrations/versions/0055_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
reviewed
Jan 7, 2025
airflow/migrations/versions/0055_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
…onomer/airflow into dag_run_migrate_conf_column_as_json
ephraimbuddy
reviewed
Jan 7, 2025
airflow/migrations/versions/0055_3_0_0_remove_pickled_data_from_dagrun_table.py
Show resolved
Hide resolved
…rate_conf_column_as_json
…rate_conf_column_as_json
…onomer/airflow into dag_run_migrate_conf_column_as_json
…rate_conf_column_as_json
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
…4533) * remove pickled data from dag run table * fix downgrade + add news fragement * remove archive table if exits after downgrade * removing archiving data * fixing static check * fixing static checks * simplying upgrade and downgrade as per review * fixing failures * removing setting conf to null * refactor approach to migrate values in conf * update offline warning * resolving conflicts * resolving conflicts * resolving conflicts * updating batch size * updaing conf type --------- Co-authored-by: Jed Cunningham <[email protected]>
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
…4533) * remove pickled data from dag run table * fix downgrade + add news fragement * remove archive table if exits after downgrade * removing archiving data * fixing static check * fixing static checks * simplying upgrade and downgrade as per review * fixing failures * removing setting conf to null * refactor approach to migrate values in conf * update offline warning * resolving conflicts * resolving conflicts * resolving conflicts * updating batch size * updaing conf type --------- Co-authored-by: Jed Cunningham <[email protected]>
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
…4533) * remove pickled data from dag run table * fix downgrade + add news fragement * remove archive table if exits after downgrade * removing archiving data * fixing static check * fixing static checks * simplying upgrade and downgrade as per review * fixing failures * removing setting conf to null * refactor approach to migrate values in conf * update offline warning * resolving conflicts * resolving conflicts * resolving conflicts * updating batch size * updaing conf type --------- Co-authored-by: Jed Cunningham <[email protected]>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
In [PR](apache#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](apache#44533 (comment)). related: apache#44166
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…4533) * remove pickled data from dag run table * fix downgrade + add news fragement * remove archive table if exits after downgrade * removing archiving data * fixing static check * fixing static checks * simplying upgrade and downgrade as per review * fixing failures * removing setting conf to null * refactor approach to migrate values in conf * update offline warning * resolving conflicts * resolving conflicts * resolving conflicts * updating batch size * updaing conf type --------- Co-authored-by: Jed Cunningham <[email protected]>
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 27, 2025
In [PR](apache/airflow#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](apache/airflow#44533 (comment)). related: apache/airflow#44166 GitOrigin-RevId: 40821bfd5c54f3a39b3ff6e8352a4e3a20323e24
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
In [PR](apache/airflow#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](apache/airflow#44533 (comment)). related: apache/airflow#44166 GitOrigin-RevId: 40821bfd5c54f3a39b3ff6e8352a4e3a20323e24
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
In [PR](apache/airflow#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](apache/airflow#44533 (comment)). related: apache/airflow#44166 GitOrigin-RevId: 40821bfd5c54f3a39b3ff6e8352a4e3a20323e24
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 26, 2026
In [PR](apache/airflow#44166) we added migration for removing pickled data from `xcom` table. During my testing I noticed with `SQLite` [insert](https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py#L88) statement is not working in case of upgrade. Changing condition to `hex(substr(value, 1, 1)) = '80'` works. Tested [here](apache/airflow#44533 (comment)). related: apache/airflow#44166 GitOrigin-RevId: 40821bfd5c54f3a39b3ff6e8352a4e3a20323e24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #43933
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.