AIP-84: Migrate Dag Parsing endpoint to FastApi#44416
Merged
pierrejeambrun merged 8 commits intoapache:mainfrom Nov 28, 2024
Merged
AIP-84: Migrate Dag Parsing endpoint to FastApi#44416pierrejeambrun merged 8 commits intoapache:mainfrom
pierrejeambrun merged 8 commits intoapache:mainfrom
Conversation
prabhusneha
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
prabhusneha
force-pushed
the
migrate_dag_parsing_endpoint
branch
from
bad0ea3 to
af1827d
Compare
Contributor
|
closed and reopened to run tests |
rawwar
reviewed
Nov 27, 2024
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice.
Looking good overall, just a few suggestions :)
prabhusneha
force-pushed
the
migrate_dag_parsing_endpoint
branch
from
941c83d to
094966a
Compare
pierrejeambrun
added
legacy api
Contributor
Author
|
Fixing the checks. |
prabhusneha
force-pushed
the
migrate_dag_parsing_endpoint
branch
from
c32838e to
b3b783d
Compare
rawwar
reviewed
Nov 28, 2024
Contributor
Author
|
Rebased and all PR comments addressed.. FYI @pierrejeambrun |
pierrejeambrun
approved these changes
Nov 28, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
One small nit, ready to merge
prabhusneha
force-pushed
the
migrate_dag_parsing_endpoint
branch
from
5fb527b to
5546e23
Compare
prabhusneha
requested review from
XD-DENG,
ashb,
bolkedebruin,
eladkal,
hussein-awala,
jedcunningham,
mik-laj,
mobuchowski,
o-nikolas and
potiuk
as code owners
prabhusneha
force-pushed
the
migrate_dag_parsing_endpoint
branch
from
5546e23 to
2cae524
Compare
pierrejeambrun
approved these changes
Nov 28, 2024
Member
|
Thanks! |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* AIP-84: Migrate Dag Parsing endpoint to FastApi * Address PR comments * Change the test class name * Address PR comments and fix tests * Address PR comment * remove database isolation option to fix failing check * Address PR comment --------- Co-authored-by: Sneha Prabhu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #42370
Testing:
API responses using legacy and fastAPI endpoints:
Legacy-API:
last_parsed_time changed in airflow.dag:
FastAPI:
last_parsed_time changed in airflow.dag: