AIP-84: Migrate Extra Links endpoint to fastapi#44277
Merged
pierrejeambrun merged 10 commits intoapache:mainfrom Nov 25, 2024
Merged
AIP-84: Migrate Extra Links endpoint to fastapi#44277pierrejeambrun merged 10 commits intoapache:mainfrom
pierrejeambrun merged 10 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:API
vatsrahul1001
added
the
legacy api
prabhusneha
force-pushed
the
extra_link_endpoint
branch
from
aa9c505 to
100a1a5
Compare
prabhusneha
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
rawwar
reviewed
Nov 22, 2024
rawwar
reviewed
Nov 22, 2024
prabhusneha
force-pushed
the
extra_link_endpoint
branch
2 times, most recently
from
11340ed to
8fda581
Compare
rawwar
reviewed
Nov 25, 2024
amoghrajesh
reviewed
Nov 25, 2024
Contributor
There was a problem hiding this comment.
Good work on the PR @prabhusneha!
Mostly looks fine, have a few comments and the static checks needs fixing.
prabhusneha
force-pushed
the
extra_link_endpoint
branch
from
8fda581 to
4f66b89
Compare
1 task
pierrejeambrun
approved these changes
Nov 25, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Great thanks.
Looking good overall, a few suggestions, and should be ready to merge once other comments are resolved.
prabhusneha
force-pushed
the
extra_link_endpoint
branch
from
3c23bf7 to
ccccba9
Compare
Contributor
Author
Rebased and resolved all comments. |
Member
|
Thanks 👍 |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* migrate extra link endpoint to fastapi * add airflow license * add tests * Apply suggestions from code review Co-authored-by: Kalyan R <[email protected]> * add teardown in test * change async to sync * Address PR comments and fix static checks * Address PR comment --------- Co-authored-by: Sneha Prabhu <[email protected]> Co-authored-by: Kalyan R <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #42370
Testing:
API responses using legacy and fastAPI endpoints:
Legacy-API:
FastAPI:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.