Fix side effect of bad grpc.Chanel mocking#44029
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 14, 2024
Merged
Conversation
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in apache#44011 in the apache#44011 (comment) Patching is now fixed via using fixtures.
Member
Author
|
Interestingly it's been there since the very beginning - i.e 2019 |
eladkal
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the #44011 (comment)
Patching is now fixed via using fixtures.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.