AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI#43874
Merged
pierrejeambrun merged 29 commits intoapache:mainfrom Nov 15, 2024
Merged
AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI#43874pierrejeambrun merged 29 commits intoapache:mainfrom
pierrejeambrun merged 29 commits intoapache:mainfrom
Conversation
Co-authored-by: Jed Cunningham <[email protected]>
amoghrajesh
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Contributor
Author
|
Only the last 3 commits are relevant here |
Member
|
The base branch has been merged, branch needs rebasing. Also you can add the |
amoghrajesh
added
the
legacy api
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks, a few suggestions
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
One small suggestion following the change of convention based on Kaxil's PR that was just merged yesterday.
Otherwise looking good and ready to merge.
Thanks
1 task
Contributor
Author
|
OK i got a green CI. Is this one good to merge @pierrejeambrun? |
rawwar
reviewed
Nov 14, 2024
This was referenced Nov 14, 2024
pierrejeambrun
approved these changes
Nov 15, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Needs rebasing, small need and ready to merge.
Member
|
Thanks 🎉 |
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…che#43874) * AIP-84: Migrating GET Assets to fastAPI * matching response to legacy * Adding unit tests - part 1 * Update airflow/api_fastapi/common/parameters.py Co-authored-by: Jed Cunningham <[email protected]> * fixing the dag_ids filter * fixing the dag_ids filter * Adding unit tests - part 2 * fixing unit tests & updating parameter type * review comments pierre * fixing last commit * fixing unit tests * AIP-84: Migrating GET Dataset events for DAG runs to fastAPI * adding test cases * adding test cases * review comments pierre * fixing unit tests * review comments pierre * review comments and fixing a test * review comments on ut --------- Co-authored-by: Jed Cunningham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #42370
Depends on #43783
Migrating the GET Dataset events for DAG runs to fastAPI
Responses:
Legacy
FastAPI
Swagger spec
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.