Further make sure graphviz is truly optional feature on MacOS#43867
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 11, 2024
Merged
Further make sure graphviz is truly optional feature on MacOS#43867potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
Fokko,
eladkal,
ferruzzi,
gopidesupavan and
hussein-awala
potiuk
force-pushed
the
remove-indirect-diagram-deps-from-darwin
branch
from
acb58d6 to
c00234c
Compare
potiuk
changed the title
potiuk
changed the title
Member
Author
|
cc: @enisnazif |
eladkal
approved these changes
Nov 11, 2024
Lee-W
approved these changes
Nov 11, 2024
gopidesupavan
approved these changes
Nov 11, 2024
Fokko
approved these changes
Nov 11, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Sounds fair to me, just left one suggestion 👍
hussein-awala
approved these changes
Nov 11, 2024
amoghrajesh
approved these changes
Nov 11, 2024
For our development, Pygraphviz is quite a difficul dependency to install on MacOS. That's why we disable it by default on MacOS - it was attempted in apache#43604, but it turned out some other dependencies pulled it in as well. This PR removes all the graphviz dependencies as being required, and providers more readable error message and iink to documuentation explaining how to install graphviz if needed.
potiuk
force-pushed
the
remove-indirect-diagram-deps-from-darwin
branch
from
c00234c to
98605eb
Compare
Member
Author
|
Another result of the Man's Hackathon :). We were lucky to have @enisnazif who had brand-new M4 Mac just set-up from scratch so I hope firrst time MacOS experience for new contributors will get better thanks to that! |
Contributor
|
A new laptop always helps find bugs in the docs :) |
Contributor
New laptops and new hires/interns. Their best first contribution is always verifying and updating docs 👍 |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…#43867) For our development, Pygraphviz is quite a difficul dependency to install on MacOS. That's why we disable it by default on MacOS - it was attempted in apache#43604, but it turned out some other dependencies pulled it in as well. This PR removes all the graphviz dependencies as being required, and providers more readable error message and iink to documuentation explaining how to install graphviz if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For our development, Pygraphviz is quite a difficul dependency to
install on MacOS. That's why we disable it by default on MacOS -
it was attempted in #43604, but it turned out some other dependencies
pulled it in as well.
This PR removes all the graphviz dependencies as being required,
and providers more readable error message and iink to documuentation
explaining how to install graphviz if needed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.