AIP-84 Get Configs / Get Config Value#43841
Conversation
e32d6a4 to
8387632
Compare
8387632 to
a97c505
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice.
A few suggestions but looking good.
7d15731 to
8a97fd4
Compare
|
Hi @pierrejeambrun, here is the update: Common
|
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks looking good, a few suggestions / question, then we can merge.
8a97fd4 to
f24d243
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Good to merge after rebase
- add `HEADERS_NONE` and `HEADERS_ANY` cases - modularize common json response cases - add `_validate_response` common method
f24d243 to
41281dc
Compare
|
Just resolve the conflict 🚀 |
|
Hello @jason810496 do you mind fixing the formatting errors, it would be great to merge this one :) |
I think, that would require us to maintain a Model with all possible configs along with their type. But, AirflowConfigParser has methods defined to typecast and reuse. Like for @bbovenzi , Should I create a separate issue? I don't think its a trivial change |
|
I would be for creating an issue, and tagging that as a feature request ? Unless this was already implemented in the legacy endpoint but I don't believe so. That would be a great addition. Full string values is quite limited and force work on the client side. |
|
I think I'll make this a feature for the UI only config endpoint |
* AIP-84 Get Config * Fix section param type and text format * Add test for Get Config * Consolidate redundant for check expose config * Add `Accept` header depends for Json and Text * Refactor config, dag_source with common header * Refactor test_config with non-sensitive-only case * Fix OpenAPI schema for Headers, Get Config * Refactor test_config - add `HEADERS_NONE` and `HEADERS_ANY` cases - modularize common json response cases - add `_validate_response` common method * Fix style by ruff format

closes: #42745
related: #42370