get_task_instance_try_details API returns TaskInstanceHistory schema by kandharvishnu · Pull Request #43830 · apache/airflow

kandharvishnu · 2024-11-08T16:22:23Z

these API requests

get_task_instance_try_details
get_mapped_task_instance_try_details
get_task_instance_tries
get_mapped_task_instance_tries

are actually returning TaskInstanceHistory

Airflow API Docs mentions that the get_task_instance_try_details return task_instance schema

But API actually returns TaskInstanceHistory schema

get_task_instance_try_details method also returns the TaskInstanceHistory

these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory

pierrejeambrun

Beside the small comment, looking good.

Maybe @ephraimbuddy can double check ?

airflow/api_connexion/openapi/v1.yaml

ephraimbuddy · 2024-11-12T15:15:42Z

There's no difference between TI and TI History except for loading related objects. It makes me wonder if we need this PR

pierrejeambrun · 2024-11-12T15:52:19Z

There's no difference between TI and TI History except for loading related objects. It makes me wonder if we need this PR

In that case exposing a TaskInstance might be sufficient and less confusing for users of the API. Otherwise they might be intrigued by TaskInstanceHistory. Maybe in this PR we can just add a comment in the code, in the TaskInstanceHistory Schema to specify that there are no differences beside loading objects, and that in terms of response TaskInstance is fine ? (All that will be deleted soon anyway).

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

kandharvishnu · 2024-11-12T15:59:51Z

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

Additionally, I noticed that the following columns are missing in TaskInstanceHistory when compared with TaskInstance:

sla_miss
rendered_map_index
rendered_fields
trigger
triggerer_job
note

ephraimbuddy · 2024-11-15T10:30:56Z

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

the logical_date/execution_date is a proxy in TaskInstance so we couldn't have it in TI history.

ephraimbuddy · 2024-11-15T10:32:29Z

Also there is the deprecated execution_date difference, maybe the TaskInstanceHistory is missing the logical_date/execution_date ?

Additionally, I noticed that the following columns are missing in TaskInstanceHistory when compared with TaskInstance:

sla_miss

rendered_map_index

rendered_fields

trigger

triggerer_job

note

Those are the differences. We can't be able to have those in TI history.

pierrejeambrun · 2024-11-15T16:21:52Z

Those are the differences. We can't be able to have those in TI history.

As there are some differences I think we need to actually fix the spec with the actual response returned. Otherwise client might expect one of those fields trigger, etc.. while those are missing.

pierrejeambrun

I recommend to wait for @ephraimbuddy second opinion before merging that. But looks good to me.

…pache#43830) * Update v1.yaml these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory * Update v1.yaml * dummy change * revert "dummy change" * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * changes to v1.yaml * Update api-generated.ts * removing execution_date --------- Co-authored-by: kandharvishnuu <[email protected]> (cherry picked from commit 6f02fdb)

…43830) (#44133) * Update v1.yaml these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory * Update v1.yaml * dummy change * revert "dummy change" * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * changes to v1.yaml * Update api-generated.ts * removing execution_date --------- Co-authored-by: kandharvishnuu <[email protected]> (cherry picked from commit 6f02fdb) Co-authored-by: kandharvishnu <[email protected]>

…pache#43830) * Update v1.yaml these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory * Update v1.yaml * dummy change * revert "dummy change" * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * changes to v1.yaml * Update api-generated.ts * removing execution_date --------- Co-authored-by: kandharvishnuu <[email protected]>

…43830) (#44133) * Update v1.yaml these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory * Update v1.yaml * dummy change * revert "dummy change" * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * Update api-generated.ts * changes to v1.yaml * Update api-generated.ts * removing execution_date --------- Co-authored-by: kandharvishnuu <[email protected]> (cherry picked from commit 6f02fdb) Co-authored-by: kandharvishnu <[email protected]>

kandharvishnu added 2 commits November 8, 2024 21:35

Update v1.yaml

ebee59d

these - get_task_instance_try_details - get_mapped_task_instance_try_details - get_task_instance_tries - get_mapped_task_instance_tries are actually returning TaskInstanceHistory

Update v1.yaml

e1f8650

kandharvishnu requested review from ephraimbuddy and pierrejeambrun as code owners November 8, 2024 16:22

boring-cyborg bot added the area:API Airflow's REST/HTTP API label Nov 8, 2024

rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 8, 2024

kandharvishnu added 3 commits November 8, 2024 22:21

dummy change

07c9399

revert "dummy change"

fa4a90b

Update api-generated.ts

14ac920

kandharvishnu requested review from ashb, bbovenzi, jscheffl and ryanahamilton as code owners November 10, 2024 17:07

kandharvishnu added 3 commits November 10, 2024 22:45

Update api-generated.ts

16d7f10

Update api-generated.ts

f08fcea

Update api-generated.ts

b9a0cde

rawwar added the legacy ui Whether legacy UI change should be allowed in PR label Nov 12, 2024

kandharvishnuu and others added 2 commits November 12, 2024 12:23

changes to v1.yaml

cf0af58

Merge branch 'main' into kandharvishnu-patch-1

1b358be

pierrejeambrun reviewed Nov 12, 2024

View reviewed changes

airflow/api_connexion/openapi/v1.yaml Outdated Show resolved Hide resolved

kandharvishnu and others added 2 commits November 12, 2024 21:12

Update api-generated.ts

fac96b4

removing execution_date

4a08301

kandharvishnu requested a review from pierrejeambrun November 12, 2024 15:45

kandharvishnu mentioned this pull request Nov 15, 2024

AIP-84 Get Task Instance Try Details #43675

Merged

pierrejeambrun approved these changes Nov 15, 2024

View reviewed changes

ephraimbuddy approved these changes Nov 18, 2024

View reviewed changes

ephraimbuddy merged commit 6f02fdb into apache:main Nov 18, 2024

pierrejeambrun mentioned this pull request Nov 18, 2024

get_task_instance_try_details API returns TaskInstanceHistory schema … #44133

Merged

kandharvishnu mentioned this pull request Nov 20, 2024

AIP-84 Get Mapped Task Instance Try Details #44206

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get_task_instance_try_details API returns TaskInstanceHistory schema#43830

get_task_instance_try_details API returns TaskInstanceHistory schema#43830
ephraimbuddy merged 12 commits intoapache:mainfrom
kandharvishnu:kandharvishnu-patch-1

kandharvishnu commented Nov 8, 2024 •

edited

Loading

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

ephraimbuddy commented Nov 12, 2024

Uh oh!

pierrejeambrun commented Nov 12, 2024 •

edited

Loading

Uh oh!

kandharvishnu commented Nov 12, 2024

Uh oh!

ephraimbuddy commented Nov 15, 2024

Uh oh!

ephraimbuddy commented Nov 15, 2024

Uh oh!

pierrejeambrun commented Nov 15, 2024

Uh oh!

pierrejeambrun left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kandharvishnu commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ephraimbuddy commented Nov 12, 2024

Uh oh!

pierrejeambrun commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kandharvishnu commented Nov 12, 2024

Uh oh!

ephraimbuddy commented Nov 15, 2024

Uh oh!

ephraimbuddy commented Nov 15, 2024

Uh oh!

pierrejeambrun commented Nov 15, 2024

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kandharvishnu commented Nov 8, 2024 •

edited

Loading

pierrejeambrun commented Nov 12, 2024 •

edited

Loading