Repository navigation
Refactor SerializedDagModel and DagCode for dag versioning - #43821
Merged
Merged
Conversation
ephraimbuddy
requested review from
XD-DENG,
ashb,
jedcunningham,
pierrejeambrun and
potiuk
as code owners
November 8, 2024 12:07
boring-cyborg
Bot
added
area:API
ephraimbuddy
force-pushed
the
versioning-refactor
branch
3 times, most recently
from
November 11, 2024 09:37
328f018 to
33f09ad
Compare
1 task done
ephraimbuddy
force-pushed
the
versioning-refactor
branch
from
November 14, 2024 19:00
33f09ad to
3fce0bd
Compare
ephraimbuddy
force-pushed
the
versioning-refactor
branch
from
November 14, 2024 19:33
3fce0bd to
17bf155
Compare
Lee-W
approved these changes
Nov 15, 2024
uranusjr
reviewed
Nov 15, 2024
uranusjr
approved these changes
Nov 15, 2024
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
One suggestion on docstring, otherwise lgtm.
Now that we have dag versioning, the SerializedDagModel and DagCode objects should no longer be deleted. Deletion should start with the DagModel, which will cascade to the DagVersion, then to the DagCode and SerializedDagModel. Also, these models are no longer updated. Instead, a new object is added; hence, the last_updated is changed to created_at.
ephraimbuddy
force-pushed
the
versioning-refactor
branch
from
November 15, 2024 08:59
17bf155 to
88ada58
Compare
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
) * Refactor SerializedDagModel and DagCode for dag versioning Now that we have dag versioning, the SerializedDagModel and DagCode objects should no longer be deleted. Deletion should start with the DagModel, which will cascade to the DagVersion, then to the DagCode and SerializedDagModel. Also, these models are no longer updated. Instead, a new object is added; hence, the last_updated is changed to created_at. * fixup! Refactor SerializedDagModel and DagCode for dag versioning * fixup! fixup! Refactor SerializedDagModel and DagCode for dag versioning * update rpc test since remove_deleted_dag has been removed * Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have dag versioning, the SerializedDagModel and DagCode objects should no longer be deleted. Deletion should start with the DagModel, which will cascade to the DagVersion, then to the DagCode and SerializedDagModel.
Also, these models are no longer updated. Instead, a new object is added; hence, the last_updated is changed to created_at.