Disable aip 44 for less than airflow 3 versions#43818
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 11, 2024
Merged
Conversation
Member
|
Exactly the errors I expected.. I guess after we have #43556 (finally) merged and rebase this one, it should fix itself :) |
jscheffl
reviewed
Nov 8, 2024
Member
Author
Yes agree :) |
gopidesupavan
force-pushed
the
set-env-varibale-aip-44-enabled
branch
from
945c89c to
eff7d95
Compare
hussein-awala
approved these changes
Nov 9, 2024
potiuk
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the CI it sets to default to true. https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/params/shell_params.py#L491
So for the other versions also its coming as true.
ex: i ran this
breeze shell --use-airflow-version 2.8.4 --mount-sources providers-and-testsand i could see its setting as true.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.