Remove Deleted backfill endpoint Tests from FAB#43654
Closed
bugraoz93 wants to merge 1 commit intoapache:mainfrom
Closed
Remove Deleted backfill endpoint Tests from FAB#43654bugraoz93 wants to merge 1 commit intoapache:mainfrom
bugraoz93 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@dstandish I think this endpoint is deleted in #43496. Deleting them should fix CI test issues but I wanted to double-check with you. I am not sure how we are going to handle the permissions and tests in the FastAPI so maybe deleting them would be a good idea for now. |
This was referenced Nov 4, 2024
jscheffl
approved these changes
Nov 4, 2024
Contributor
Author
|
I think mine is a duplicate of #43649. I am closing this one. |
Contributor
Author
|
Thanks a lot for a swift review @jscheffl! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #43496
The endpoint in the tests is deleted in the related PR. Deleting them should fix CI test issues. This is blocking the PRs too.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.