Remove the ability to import executors from plugins#43289
Conversation
kaxil
requested review from
XD-DENG,
ashb,
bbovenzi,
hussein-awala,
jscheffl,
o-nikolas,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:Executors-core
kaxil
added
the
airflow3.0:breaking
kaxil
force-pushed
the
remove-executor-support-from-plugin
branch
from
71ccbc7 to
1e673d6
Compare
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I think we have a still ongoing discussion, not voted towards future scope of provders package. I think this discussion should settle first.
It would also mean that if this PR is merged, that the executor descriptions in provider packages need to be removed - or at least be deprecated until Airflow 2.x support is generated.
@jscheffl The change in this PR just impact importing executors "via plugins": https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/plugins.html#plugins It is not removing executors from Providers |
kaxil
force-pushed
the
remove-executor-support-from-plugin
branch
from
1e673d6 to
5bb9663
Compare
Executors should no longer be registered or imported via Airflow's plugin mechanism -- these types of classes are just treated as plain python classes by Airflow, so there is no need to register them with Airflow. # Conflicts: # tests/plugins/test_plugin.py
kaxil
force-pushed
the
remove-executor-support-from-plugin
branch
from
5bb9663 to
768bb3c
Compare
Executors should no longer be registered or imported via Airflow's plugin mechanism -- these types of classes are just treated as plain python classes by Airflow, so there is no need to register them with Airflow.
Executors should no longer be registered or imported via Airflow's plugin mechanism -- these types of classes are just treated as plain python classes by Airflow, so there is no need to register them with Airflow.
Executors should no longer be registered or imported via Airflow's plugin mechanism -- these types of classes are just treated as plain python classes by Airflow, so there is no need to register them with Airflow.
4 participants
Executors should no longer be registered or imported via Airflow's plugin mechanism -- these types of classes are just treated as plain python classes by Airflow, so there is no need to register them with Airflow.
We had already removed it from our docs: https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/plugins.html#plugins
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.