Migrate the public endpoint Get DAG Source to FastAPI#43084
Merged
pierrejeambrun merged 2 commits intoapache:mainfrom Oct 30, 2024
Merged
Migrate the public endpoint Get DAG Source to FastAPI#43084pierrejeambrun merged 2 commits intoapache:mainfrom
pierrejeambrun merged 2 commits intoapache:mainfrom
Conversation
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
3 times, most recently
from
3042ffe to
823df79
Compare
omkar-foss
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
2 times, most recently
from
13706b3 to
c4e75f1
Compare
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
from
c4e75f1 to
a0da746
Compare
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
from
a0da746 to
fd004ac
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
I think we are missing the @mark_fastapi_migration_done
pierrejeambrun
added
the
legacy api
pierrejeambrun
force-pushed
the
aip-84/dags/get-dag-source
branch
from
99fc84a to
5127bff
Compare
omkar-foss
requested review from
ashb,
eladkal,
hussein-awala,
jedcunningham,
josh-fell,
mobuchowski,
o-nikolas,
potiuk and
uranusjr
as code owners
Collaborator
Author
|
Please ignore the request for review notification, reviewers got auto-added due to a large diff w.r.t My apologies for the spam! :) |
omkar-foss
removed request for
XD-DENG,
ashb,
bolkedebruin,
dstandish,
eladkal,
hussein-awala,
jedcunningham,
josh-fell,
mobuchowski,
o-nikolas,
potiuk and
uranusjr
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
2 times, most recently
from
5127bff to
a1eea28
Compare
Collaborator
Author
|
All conversations resolved, synced with |
pierrejeambrun
approved these changes
Oct 29, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice. Needs rebasing to fix conflicts but ready to merge after that.
Co-authored-by: pierrejeambrun <[email protected]>
omkar-foss
force-pushed
the
aip-84/dags/get-dag-source
branch
from
a1eea28 to
50ee32c
Compare
Collaborator
Author
Synced with |
pierrejeambrun
approved these changes
Oct 30, 2024
Member
|
Nice work, thanks |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate public endpoint Get DAG Source to FastAPI, with main resynced Co-authored-by: pierrejeambrun <[email protected]> * Re-run static checks --------- Co-authored-by: pierrejeambrun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #42876
Related: #42370
This migrates the Get DAG Source API from
api_connexiontoapi_fastapi.