Skip to content

Migrate the public endpoint Delete DAG to FastAPI#42914

Merged
pierrejeambrun merged 2 commits intoapache:mainfrom
omkar-foss:aip-84/dags/delete-dag
Oct 15, 2024
Merged

Migrate the public endpoint Delete DAG to FastAPI#42914
pierrejeambrun merged 2 commits intoapache:mainfrom
omkar-foss:aip-84/dags/delete-dag

Conversation

@omkar-foss
Copy link
Collaborator

closes: #42650
related: #42370

This migrates the Delete DAG API from api_connexion to api_fastapi, with a supporting test.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 10, 2024
@omkar-foss omkar-foss marked this pull request as draft October 10, 2024 19:27
@omkar-foss omkar-foss force-pushed the aip-84/dags/delete-dag branch from 2978c05 to a61f80f Compare October 10, 2024 20:00
@omkar-foss omkar-foss marked this pull request as ready for review October 10, 2024 20:01
@omkar-foss omkar-foss requested a review from ashb as a code owner October 10, 2024 20:01
@omkar-foss omkar-foss force-pushed the aip-84/dags/delete-dag branch 2 times, most recently from 317a424 to 2ec7b6d Compare October 11, 2024 16:46
@omkar-foss
Copy link
Collaborator Author

Merge conflict resolved, PR is ready for review.

@omkar-foss omkar-foss force-pushed the aip-84/dags/delete-dag branch from fd5cac9 to d3b73c3 Compare October 11, 2024 17:22
@omkar-foss
Copy link
Collaborator Author

Tests failing after adding migration marker for legacy APIs. Could someone please add the legacy api label to this PR? Thanks.

@pierrejeambrun pierrejeambrun added the legacy api Whether legacy API changes should be allowed in PR label Oct 11, 2024
@pierrejeambrun
Copy link
Member

Label added :)

@omkar-foss
Copy link
Collaborator Author

The mypy tests for mark_fastapi_migration_done had been failing, so have updated it's signature to be more tolerant here. Tests passing now.

pierrejeambrun
pierrejeambrun previously approved these changes Oct 14, 2024
@pierrejeambrun pierrejeambrun dismissed their stale review October 14, 2024 07:58

Approved by mistake.

@omkar-foss omkar-foss force-pushed the aip-84/dags/delete-dag branch from c00bef1 to 50a258e Compare October 15, 2024 05:36
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun merged commit 6c9c327 into apache:main Oct 15, 2024
@omkar-foss omkar-foss deleted the aip-84/dags/delete-dag branch October 15, 2024 09:09
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
* Migrate the public endpoint Delete DAG to FastAPI

* Refactor tests
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
* Migrate the public endpoint Delete DAG to FastAPI

* Refactor tests
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
* Migrate the public endpoint Delete DAG to FastAPI

* Refactor tests
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate the public endpoint Delete DAG to FastAPI

* Refactor tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Delete DAG to FastAPI

2 participants