AIP-84 Migrate get connections to FastAPI API #42571#42782
Merged
pierrejeambrun merged 8 commits intoapache:mainfrom Oct 15, 2024
Merged
AIP-84 Migrate get connections to FastAPI API #42571#42782pierrejeambrun merged 8 commits intoapache:mainfrom
pierrejeambrun merged 8 commits intoapache:mainfrom
Conversation
bugraoz93
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
bugraoz93
commented
Oct 6, 2024
Contributor
Author
|
Could someone please include |
gopidesupavan
added
the
legacy api
Member
done.. |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Yes we need the model for the default fallback Model to look for columns.
Few minor suggestions.
…ections endpoint to fastapi
…ss already have abstract
…strategy for backcompat
…removed unnecessary attribute mapping keys
pierrejeambrun
force-pushed
the
feat/42591/get-connections-to-fastapi
branch
from
90b4f4c to
b1a0c9f
Compare
Member
|
I just rebased the branch and resolved merge conflicts. I think we are good to go. |
pierrejeambrun
approved these changes
Oct 15, 2024
Member
|
Merging because we need that for other PRs. (dynamic order_by). We can adjust with following PR if needed. |
Contributor
Author
Make sense! I don't want to block anyone in the development flow. At least, you have already driven it and finalised the work so that it didn't block anyone for a long time. |
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #42591
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.