Include Selective Check to Ping Maintainer about Legacy WWW and API Changes#42758
Merged
potiuk merged 3 commits intoapache:mainfrom Oct 5, 2024
Merged
Conversation
…ng maintainers about updating legacy ui or legacy api code piece
bugraoz93
commented
Oct 5, 2024
potiuk
reviewed
Oct 5, 2024
potiuk
approved these changes
Oct 5, 2024
Member
|
I added labels.
|
Member
|
BTW. @bugraoz93 -> one more small change could be to add a unit test for that -> we have a number of tests in selective checks - so maybe that case could also be unit-tested. |
2 tasks
Contributor
Author
|
Thanks @potiuk! I missed the unit test part. 😅 I created a task to follow up from there. I will include them soon :) |
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…hanges (apache#42758) * Include new check in selective_checks.py for checking PR labels to ping maintainers about updating legacy ui or legacy api code piece * Remove airflow/api from LEGACY_API_FILES
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…hanges (apache#42758) * Include new check in selective_checks.py for checking PR labels to ping maintainers about updating legacy ui or legacy api code piece * Remove airflow/api from LEGACY_API_FILES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #42031
Include new check in selective_checks.py for checking PR labels to ping maintainers about updating legacy ui or legacy api code piece
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.