Skip to content

[AIRFLOW-3432] Add test for feature "Delete DAG in UI" #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaxil merged 1 commit into from
Dec 2, 2018
Merged

[AIRFLOW-3432] Add test for feature "Delete DAG in UI" #4266

kaxil merged 1 commit into from
Dec 2, 2018

Conversation

@XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Dec 2, 2018

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Earlier, PR #4069 fixed an issue of "Delete DAG in UI" feature. But it didn't provide test coverage accordingly.

This PR aims for adding test for it (both www/ and www_rbac).

Code Quality

  • Passes flake8

@XD-DENG
Copy link
Member Author

XD-DENG commented Dec 2, 2018

Hi @ashb , this PR is to add test for the PR #4069 in which aoen fixed the issue in deletion of DAGs in the UI feature.

Hi @kaxil , understand that you have already cherry-picked the fix from #4069 into 1.10.2. I would suggest to cherry-pick this PR into branch 1-10-test as well so that we can release the fix in #4069 with more confidence (lack of test was partially why that fix was not in 1.10.1).

Thanks!

@codecov-io
Copy link

codecov-io commented Dec 2, 2018 •
edited
Loading

Codecov Report

Merging #4266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4266   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files         201      201           
  Lines       16455    16455           
=======================================
  Hits        12848    12848           
  Misses       3607     3607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2115d...da2a66b. Read the comment docs.

@kaxil
Copy link
Member

kaxil commented Dec 2, 2018

@XD-DENG Can you change the name of the PR & commit to something that is easy to read in Changelog??

@XD-DENG
[AIRFLOW-3432] Add test for feature "Delete DAG in UI"
da2a66b 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
@XD-DENG XD-DENG force-pushed the test_for_ui_delete_dag branch from 2b53f03 to da2a66b Compare December 2, 2018 14:53
@XD-DENG XD-DENG changed the title [AIRFLOW-3432] Add test for [AIRFLOW-3233](PR #4069) [AIRFLOW-3432] Add test for feature "Delete DAG in UI" Dec 2, 2018
@XD-DENG
Copy link
Member Author

XD-DENG commented Dec 2, 2018

Thanks @kaxil for reminding.

I updated PR name/commit subject/JIRA ticket summary, as suggested.

Thanks!

@kaxil kaxil merged commit 1596eca into apache:master Dec 2, 2018
kaxil pushed a commit that referenced this pull request Dec 2, 2018
@XD-DENG @kaxil
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (#4266)
7aa4c76 
Related Commits:
1. [AIRFLOW-2657](PR #3531)
2. [AIRFLOW-3233](PR #4069)

Added for both www/ and www_rbac
@XD-DENG XD-DENG deleted the test_for_ui_delete_dag branch December 2, 2018 23:34
elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018
@XD-DENG @elizabethhalper
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)
136f450 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@XD-DENG
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)
c452ebc 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
kaxil pushed a commit that referenced this pull request Jan 9, 2019
@XD-DENG @kaxil
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (#4266)
c17946e 
Related Commits:
1. [AIRFLOW-2657](PR #3531)
2. [AIRFLOW-3233](PR #4069)

Added for both www/ and www_rbac
ashb pushed a commit to ashb/airflow that referenced this pull request Jan 10, 2019
@XD-DENG @ashb
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)
721fc3c 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
@XD-DENG
Add test for feature "Delete DAG in UI" (apache#4266)
9f74b2f 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
@XD-DENG
[AIRFLOW-3432] Add test for feature "Delete DAG in UI" (apache#4266)
f4705db 
Related Commits:
1. [AIRFLOW-2657](PR apache#3531)
2. [AIRFLOW-3233](PR apache#4069)

Added for both www/ and www_rbac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XD-DENG @codecov-io @kaxil