AIP-84 Migrate delete a connection to FastAPI API#42571
Merged
pierrejeambrun merged 10 commits intoapache:mainfrom Oct 2, 2024
Merged
AIP-84 Migrate delete a connection to FastAPI API#42571pierrejeambrun merged 10 commits intoapache:mainfrom
pierrejeambrun merged 10 commits intoapache:mainfrom
Conversation
bugraoz93
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
pierrejeambrun
approved these changes
Sep 30, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice 👍.
A couple of really minor nits / suggestions, but that is already in a mergeable state :)
# Conflicts: # airflow/ui/openapi-gen/queries/common.ts # airflow/ui/openapi-gen/queries/queries.ts
Contributor
Author
Thanks for all of your comments! :) All are valuable 🙏 |
Member
|
Thanks. Can you rebase the PR, we just merged a new change that updates the Basically you need to use the I think it might also solves the conflicts. |
# Conflicts: # airflow/api_fastapi/views/public/__init__.py # airflow/ui/openapi-gen/requests/services.gen.ts
Contributor
Author
|
I fixed the conflict and generated files again. Great addition, thanks! Indeed, they were quite long :) |
pierrejeambrun
approved these changes
Oct 2, 2024
Member
|
Thanks @bugraoz93 |
pierrejeambrun
added a commit
that referenced
this pull request
Oct 15, 2024
* Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Include connections router and migrate delete a connection endpoint to fastapi * Mark tests as db_test * Use only pyfixture session * make method async * setup method to setup_attrs * Convert APIRouter tags, make setup method unified * Use AirflowRouter over fastapi.APIRouter
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Include connections router and migrate delete a connection endpoint to fastapi * Mark tests as db_test * Use only pyfixture session * make method async * setup method to setup_attrs * Convert APIRouter tags, make setup method unified * Use AirflowRouter over fastapi.APIRouter
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
) * Make SortParam parent for Model Specific SortParams, Include get connections endpoint to fastapi * Change depends() method regular method in SortParam due to parent class already have abstract * Remove subclass, get default order_by from primary key, change alias strategy for backcompat * pre-commit hooks * Dynamic return value of SortParam generated within openapi specs and removed unnecessary attribute mapping keys * Include connection_id to attr_mapping again * Dynamic depends with correct documentation * Add more tests --------- Co-authored-by: pierrejeambrun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #42559
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.