Skip to content

Conversation

@vincbeck
Copy link
Contributor

A new major version will be released in the Amazon provider package (see breaking change in #42218). As such, it is a good time to do some clean up.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck
Copy link
Contributor Author

Tests are expected to fail. I'll resolve them

@eladkal
Copy link
Contributor

eladkal commented Sep 25, 2024

We need change log entry explaining what we broke (list of items)

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few spot checks, it's a large PR, but what I looked at seems good and the tests passing.

@vincbeck
Copy link
Contributor Author

vincbeck commented Sep 26, 2024

@eladkal Could you check that the changelog looks good to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants