-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIRFLOW-XXX] Correct typos in UPDATING.md #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Started with "habe", "serever" and "certificiate" needing to be: "have", "server", and "certificate". Ran a check, ignoring British and US accepted spellings. Kept jargon. EG admin, aync, auth, backend, config, dag, s3, utils, etc. Took exception to: "num of dag run" meaning "number of dag runs", "upness" is normally for quarks, "url" being lower-case, and sftp example having an excess file ending. Python documentation writes "builtin" hyphenated, cases "PYTHONPATH". Gave up on mixed use of "dag" and "DAG" as well as long line lengths.
feng-tao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. lgtm
|
Welcome; not sure how you mange the diffs from the master and stable branch to this doc. |
|
just found out that you are updating the v10 branch. cc @ashb , I am not sure if we still update the release branch though. |
|
I saw on the JIRA it's possible to mark fixed in 1.10.2, so that's why I make this pull request. That |
|
thanks @dlamblin , I don't think we need to worry about that unit test fails for this pr given it just changes the doc. |
|
@kaxil , so this won't go into pypi unless we manually push so, right? So what is the purpose of merging this change into both master branch and v10 branch? And have we had consensus on whether we are going to maintain/ update all the release branch? And what pr should go to both release branch and master branch? |
|
@feng-tao You are right, I had merged it in the morning and didn't release it pointed to 1.10 branch and then dropped that commit as I saw it went to 1.10 branch :) We would not want anything to change our stable branches. |
|
thanks @kaxil |
|
And yes, PyPI releases are entirely a manual process. |
|
Thanks @dlamblin |
Make sure you have checked all steps below.
Jira
Description
Applies to v1-10-stable; another pull will apply to master.
"have", "server", and "certificate".
Tests
Commits
Documentation
Code Quality
flake8