log handler deprecated filename_template argument removal#41552
log handler deprecated filename_template argument removal#41552uranusjr merged 4 commits intoapache:mainfrom
Conversation
|
This PR involves both core and provider changes. The parameter in question is public API which is why we deprecate it first. Now main is Airflow 3 so we can remove it but providers must still be compatible with Airflow 2... so how can we remove it from providers safely now? |
Right now, this field is not being used and has no effect. The filename_template is optional argument with default value None.
As I said in the above statement, the providers can still work with airflow 2. |
|
@eladkal is right - if someone installs the new provider witn an old configuration in Airlfow 2 with filename_template, it will just fail with "attemptign to iniitalize handlew with "filename_template" argument passed but it's missing" (or smth like that). |
|
I see the keyword arguments for the all the
Yah. You are right. Most of them are supporting keyword arguments except one/two (like. es handler). |
|
Just reverting will not be enough, but I think if the base Handler will accept extra arguments (and ignores them) we should be home |
Passing filename_template to a log handler is deprecated and has no effect. So, removing deprecated filename_template argument in log handler.