[AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Fokko merged 1 commit into master from kaxil-patch-1

Nov 5, 2018

Member

kaxil commented Nov 5, 2018

Make sure you have checked all steps below.

Jira

My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3262

Description

Here are some details about my PR, including screenshots of any UI changes:
Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

Currently, test in v1.10-test is failing

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Documentation

In case of new functionality, my PR adds documentation that describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

Passes flake8


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com

bf33890

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

kaxil requested a review from ashb

November 5, 2018 17:01

Fokko approved these changes

View reviewed changes

Contributor

Fokko left a comment

Fokko merged commit 7dfe235 into master

Fokko pushed a commit that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (#4135)

a632dad

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

kaxil deleted the kaxil-patch-1 branch

November 5, 2018 22:34

ashb added a commit that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests

c084e97

This changes thee tests in [AIRFLOW-3262]/(#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

ashb mentioned this pull request

[AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests #4144

Merged

6 tasks

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (#4144)

dab0c78

This changes the tests in [AIRFLOW-3262]/(#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

kaxil pushed a commit that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (#4144)

This changes the tests in [AIRFLOW-3262]/(#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

wyndhblb pushed a commit to asappinc/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

fed5ba0

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

wyndhblb pushed a commit to asappinc/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

b6b2c9a

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

836be8d

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

880a240

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

tmiller-msft pushed a commit to cse-airflow/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

4e1017e

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

tmiller-msft pushed a commit to cse-airflow/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

0c3658d

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

4aa83a5

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

787c4be

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

b53843c

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

33b9ce6

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request


          Update SimpleHttpOpTests to check Example.com (apache#4135)

8e85896

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request


          Use mocking in SimpleHttpOperator tests (apache#4144)

9f91587

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request


          [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com (apache#…

358c8e8

…4135)

Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't get banned.

wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request


          [AIRFLOW-XXX] Use mocking in SimpleHttpOperator tests (apache#4144)

6d901c9

This changes the tests in [AIRFLOW-3262]/(apache#4135) to use requests_mock
rather than making actual HTTP requests as we have had this test fail on
Travis with connection refused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet