[Databricks Provider] Revert PRs #40864 and #40471#41050
Merged
pankajkoti merged 2 commits intoapache:mainfrom Jul 27, 2024
Merged
[Databricks Provider] Revert PRs #40864 and #40471#41050pankajkoti merged 2 commits intoapache:mainfrom
pankajkoti merged 2 commits intoapache:mainfrom
Conversation
Member
Author
|
cc: @boraberke for your information. I guess it would be better if we rework on the earlier issue peacefully and clear the path for the upcoming release. Hope you're comfortable with the approach :) |
…ms, Jinja expression values (apache#40471)" This reverts commit 4fb2140.
pankajkoti
force-pushed
the
revert-pr-40864-pr-40471
branch
from
d8a7803 to
b742a92
Compare
potiuk
approved these changes
Jul 26, 2024
Contributor
Sure, thanks for letting me know! I did not have enough time to check if the issue has resurfaced or not. Maybe even it will be better if someone who's more experienced or have used these operators can fix it in a cleaner way :) |
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts PR #40864 and PR #40471.
Previously, PR #40471 was contributed to address issue #35433.
However, that contribution gave rise to another issue #40788.
Next #40788 was being attempted to be resolved in PR #40864.
However, with the second PR, it appears that the previous old
issue #35433 has resurfaced. So, at the moment, the case is
that we have 2 PRs on top of the existing implementation
eventually having nil effect and the previous issues persists.
I believe it is better to revert those 2 PRs, reopen the earlier
issue #35433 and peacefully address it by taking the needed time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.