Skip to content

[HOLD][AIRFLOW-2973] Use Python 3.6.x everywhere possible #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tedmiston wants to merge 1 commit into from
Closed

[HOLD][AIRFLOW-2973] Use Python 3.6.x everywhere possible #3816

tedmiston wants to merge 1 commit into from

Conversation

@tedmiston
Copy link
Contributor

@tedmiston tedmiston commented Aug 28, 2018

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR is similar in nature / complementary to @kaxil's #3815.

  • Add Python 3.6 support to PyPI, tox, Travis CI
  • Update dev docs to recommend 3.6.x
  • Update MLEngine operator tests to use 3.6
  • Update Kubernetes ExtractXcomPodRequestFactory pod spec to use 3.6

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Already covered by existing tests. I'm currently waiting on the CI to see if this breaks any existing unit tests.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@tedmiston
[AIRFLOW-2973] Use Python 3.6.x everywhere possible
385246f 
- Add Python 3.6 support to PyPI, tox, Travis CI
- Update dev docs to recommend 3.6.x
- Update MLEngine operator tests to use 3.6
- Update Kubernetes ExtractXcomPodRequestFactory pod spec to use 3.6
@tedmiston tedmiston mentioned this pull request Aug 28, 2018
Closed
6 tasks
@kaxil
Copy link
Member

kaxil commented Aug 28, 2018 •
edited
Loading

I have merged this changes to my PR @tedmiston . Thanks.

It would be great if you can test Python 3.7 and as Bolke mentioned, we can then replace 3.6 with 3.7 :)

@Fokko
Copy link
Contributor

Fokko commented Aug 29, 2018

This will add a lot of load to Travis, which we don't really want since Apache infra has to pay for this. My suggestion would be to set the tests to Python 3.6.

@tedmiston tedmiston changed the title [AIRFLOW-2973] Use Python 3.6.x everywhere possible [HOLD][AIRFLOW-2973] Use Python 3.6.x everywhere possible Aug 29, 2018
@tedmiston
Copy link
Contributor Author

tedmiston commented Aug 29, 2018

@Fokko That makes sense, and I agree with you there.

I reassigned the "upgrade to 3.6" Jira issue to @kaxil yesterday where he merged these changes into #3815, but then they were reverted back. Maybe we can keep his PR focused on the PyPI and tox setup of multiple subversions of Python 3 and then this one can become just upgrading the other bits that it changes above.

My understanding is that both this and #3815 are on hold until the Docker image is reworked to support having multiple subversions of Python 3.

Once that exists, I believe the changes on this branch should "just work".

@kaxil
Copy link
Member

kaxil commented Aug 29, 2018 •
edited
Loading

Yes sorry for that, I was trying to fix the issue and then debugged that it was related to our Docker CI setup and then just reverted some changes. I think we should change this PR for 3.7 (I will add the changes I made y'day in a sec to #3815 for Py3.6) as I mentioned in #3815 . You have already started working on it, which is really great @tedmiston .

kaxil
kaxil reviewed Aug 29, 2018
View reviewed changes
.travis.yml
- TOX_ENV=py35-backend_mysql PYTHON_VERSION=3
- TOX_ENV=py35-backend_sqlite PYTHON_VERSION=3
- TOX_ENV=py35-backend_postgres PYTHON_VERSION=3
- TOX_ENV=py36-backend_mysql PYTHON_VERSION=3
Copy link
Member

@kaxil kaxil Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, remember we would be just testing a single python 3 version, which would be either 3.6 and then updated to 3.7 instead of 3.5 . So you can remove py35 lines

@gerardo gerardo mentioned this pull request Oct 8, 2018
Open
@dbohomiakov dbohomiakov mentioned this pull request Nov 7, 2018
Merged
@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 10, 2018
@stale stale bot closed this Dec 18, 2018
@schnie schnie deleted the python-3.6-everywhere branch February 8, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaxil kaxil kaxil left review comments

Assignees

No one assigned

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tedmiston @kaxil @Fokko