-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIRFLOW-2860] DruidHook: time variable is not updated correctly when… #3707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… checking for timeout
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @awelsh93 Thanks
|
Hey @Fokko, thanks for your quick response. I've noticed some of the Travis jobs have failed - specifically for test_submit_timeout in What course of action do you recommend? |
|
@awelsh93 Thanks for the quick response. Maybe add an assert that the |
|
@awelsh93 I've reverted the commit for now since it fails the build. Could you create a new PR with the fixed test? |
… checking for timeout (apache#3707)
…tly when checking for timeout (apache#3707)" This reverts commit d12aacd.
… checking for timeout (apache#3707)
…tly when checking for timeout (apache#3707)" This reverts commit d12aacd.
… checking for timeout
Make sure you have checked all steps below.
Jira
Description
Tests
I ran
nosetests /tests/hooks/test_druid_hook.pyCommits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff