Skip to content

Conversation

@andscoop
Copy link
Contributor

@andscoop andscoop commented Aug 5, 2018

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Setting up a local docker test environment was breaking due to the additional of the verify_gpl_dependency in setup.py. This PR fixes that by passing in the SLUGIFY_USES_TEXT_UNIDECODE=yes env to docker run

It also now uses the -w arg on docker run in order to put user directly into /airflow dir. This removes the need to cd into that directory in the next step.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Who will test the tests?

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

Codecov Report

Merging #3701 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
- Coverage   77.56%   77.55%   -0.01%     
==========================================
  Files         204      204              
  Lines       15766    15766              
==========================================
- Hits        12229    12228       -1     
- Misses       3537     3538       +1
Impacted Files Coverage Δ
airflow/models.py 88.54% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3157287...fab2e7e. Read the comment docs.

@feng-tao feng-tao mentioned this pull request Aug 6, 2018
6 tasks
@bolkedebruin bolkedebruin merged commit 8687ab9 into apache:master Aug 8, 2018
bolkedebruin pushed a commit that referenced this pull request Aug 8, 2018
…run (#3701)

(cherry picked from commit 8687ab9)
Signed-off-by: Bolke de Bruin <[email protected]>
bolkedebruin pushed a commit that referenced this pull request Aug 8, 2018
…run (#3701)

(cherry picked from commit 8687ab9)
Signed-off-by: Bolke de Bruin <[email protected]>
(cherry picked from commit 3670d49)
Signed-off-by: Bolke de Bruin <[email protected]>
lxneng pushed a commit to lxneng/incubator-airflow that referenced this pull request Aug 10, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
(cherry picked from commit 8687ab9)
Signed-off-by: Bolke de Bruin <[email protected]>
(cherry picked from commit 3670d49)
Signed-off-by: Bolke de Bruin <[email protected]>
@schnie schnie deleted the update-docker-docs-to-account-for-verify-gpl-dep-change branch February 8, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants