Add Architecture Decision Record for common.sql introduction#36015
Add Architecture Decision Record for common.sql introduction#36015potiuk merged 1 commit intoapache:mainfrom
Conversation
9dfde8c to
abae161
Compare
airflow/providers/common/sql/doc/adr/0001-record-architecture-decisions.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks good generally, few nit picking comments on usage of DBApi vs DBAPI
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
...oviders/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md
Outdated
Show resolved
Hide resolved
461a0a3 to
9a7a10f
Compare
|
I have some questions, I don't have any suggestions yet, but after some discussion we might have the right answer and add to this document, or upcoming updates.
|
Yep. I think those are great questions and I propose to add and discuss separate ADR entry for each of those questions - this is precisely what ADRs are for - separate ADR for each such decision. I think what we did with comon.sql was just "basic" commonalisation" and we shoudl continue with all the points you raised. I will merge it now. And we can discuss each of thsoe separately and propose ADRs for them individually. |
Fixes: #35874
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.