Use base aws classes in Amazon S3 Glacier Operators/Sensors#35108
Merged
vincbeck merged 3 commits intoapache:mainfrom Oct 24, 2023
Merged
Use base aws classes in Amazon S3 Glacier Operators/Sensors#35108vincbeck merged 3 commits intoapache:mainfrom
vincbeck merged 3 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon
Taragolis
commented
Oct 23, 2023
Comment on lines
-38
to
+40
| def __init__(self, aws_conn_id: str = "aws_default") -> None: | ||
| super().__init__(client_type="glacier") | ||
| self.aws_conn_id = aws_conn_id | ||
| def __init__(self, *args, **kwargs) -> None: | ||
| kwargs.update({"client_type": "glacier", "resource_type": None}) | ||
| super().__init__(*args, **kwargs) |
Contributor
Author
There was a problem hiding this comment.
Accidentally found that GlacierHook only allows aws_conn_id and ignore other AwsBaseHook's parameters
vincbeck
approved these changes
Oct 23, 2023
eladkal
approved these changes
Oct 24, 2023
syedahsn
approved these changes
Oct 24, 2023
27 tasks
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.