Skip to content

Update operator_extra_links property#34506

Merged
Taragolis merged 2 commits intoapache:mainfrom
asherkhb:fix_mapped_batch_operator
Sep 21, 2023
Merged

Update operator_extra_links property#34506
Taragolis merged 2 commits intoapache:mainfrom
asherkhb:fix_mapped_batch_operator

Conversation

@asherkhb
Copy link
Contributor

@asherkhb asherkhb commented Sep 20, 2023 •
edited
Loading

Updates the Amazon AWS Batch operator to work with dynamic task mapping.

The current implementation of operator_extra_links as a property causes an airflow.exceptions.SerializationError when used in Dynamic Task Mapping, as it attempts to access two attributes which are not present in the MappedOperator class. To avoid this exception, this change updates the property to conditionally pull these attributes from the alternative attributes when necessary.

e.g.

Broken DAG: [/opt/airflow/dags/broken_dag.py] Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/serialization/serialized_objects.py", line 848, in _serialize_node
    op.operator_extra_links.__get__(op)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/amazon/aws/operators/batch.py", line 129, in operator_extra_links
    if self.wait_for_completion:
AttributeError: 'MappedOperator' object has no attribute 'wait_for_completion'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/serialization/serialized_objects.py", line 1394, in to_dict
    json_dict = {"__version": cls.SERIALIZER_VERSION, "dag": cls.serialize_dag(var)}
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/serialization/serialized_objects.py", line 1317, in serialize_dag
    raise SerializationError(f"Failed to serialize DAG {dag.dag_id!r}: {e}")
airflow.exceptions.SerializationError: Failed to serialize DAG 'broken': 'MappedOperator' object has no attribute 'wait_for_completion'

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 20, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@hussein-awala
Copy link
Member

hussein-awala commented Sep 20, 2023

The current implementation of operator_extra_links as a property causes an airflow.exceptions.SerializationError when used in Dynamic Task Mapping

Could you add the full exception to the PR description?

@Taragolis Taragolis merged commit 04515ef into apache:main Sep 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal mentioned this pull request Oct 13, 2023
Closed
98 tasks
This was referenced Oct 16, 2023
Merged
Closed
@Taragolis Taragolis mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussein-awala hussein-awala hussein-awala approved these changes

@o-nikolas o-nikolas o-nikolas approved these changes

@eladkal eladkal Awaiting requested review from eladkal

Assignees

No one assigned

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asherkhb @hussein-awala @o-nikolas @Taragolis