Skip to content

[AIRFLOW-2544] Guard against next major release of Celery, Flower #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tedmiston wants to merge 1 commit into from
Closed

[AIRFLOW-2544] Guard against next major release of Celery, Flower #3439

tedmiston wants to merge 1 commit into from

Conversation

@tedmiston
Copy link
Contributor

@tedmiston tedmiston commented May 30, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR proactively guards against the next major version of Celery (4.2) from being installed automatically until it's been tested. It is currently in RC but not yet officially released. I've also added an upper bound on Flower 1.0 similarly.

Related to https://issues.apache.org/jira/browse/AIRFLOW-1967, and created from discussion in #2806.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

n/a - just a dependency version guard

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

n/a

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@tedmiston
Copy link
Contributor Author

tedmiston commented May 30, 2018

@Fokko Here is the PR I proposed yesterday in #2806 (comment) that covers Celery. I also added a similar guard for the 1.0 release of Flower as well. It looks like master was recently changed to celery>=4.1.1 so I have preserved that. Let me know if this looks good to you to merge. Thank you!

@tedmiston tedmiston mentioned this pull request May 30, 2018
Closed
4 tasks
@codecov-io
Copy link

codecov-io commented May 30, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3ed25a9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3439   +/-   ##
=========================================
  Coverage          ?   76.68%           
=========================================
  Files             ?      203           
  Lines             ?    15064           
  Branches          ?        0           
=========================================
  Hits              ?    11552           
  Misses            ?     3512           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed25a9...7d396ad. Read the comment docs.

@tedmiston
Copy link
Contributor Author

tedmiston commented May 30, 2018

^ Not sure what this Codecov warning is about. This PR doesn't change code, so I think it's not relevant, but please let me know if action is required.

@tedmiston tedmiston force-pushed the celery-flower-guard branch from 7b50fb1 to 7d396ad Compare May 30, 2018 20:58
@tedmiston
Copy link
Contributor Author

tedmiston commented May 30, 2018

Rebased off master to see if it makes a difference.

@tedmiston
Copy link
Contributor Author

tedmiston commented Jun 1, 2018

@bolkedebruin I noticed you'd done some work around Celery as well. Do you have any input on this one?

@Fokko
Copy link
Contributor

Fokko commented Jun 1, 2018

Thanks @tedmiston. Codecov is sometimes a bit off if you're working on an outdated master. Looking good.

@r39132
Copy link
Contributor

r39132 commented Jun 1, 2018

LGTM

@asfgit asfgit closed this in 8a5e513 Jun 1, 2018
@cloneluke cloneluke mentioned this pull request Jun 1, 2018
Closed
4 tasks
@tedmiston tedmiston deleted the celery-flower-guard branch June 1, 2018 22:53
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@tedmiston
[AIRFLOW-2544][AIRFLOW-1967] Guard against next major release of Cele…
364d1f6 
…ry, Flower

Closes apache#3439 from tedmiston/celery-flower-guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tedmiston @codecov-io @Fokko @r39132