[AIRFLOW-2510] Introduce new macros: prev_ds and next_ds #3418
Conversation
airflow/models.py
Outdated
There was a problem hiding this comment.
per discussion, I wonder if we could have a better default value here .
But good to see the travis CI pass :)
There was a problem hiding this comment.
The idea of {{ next_ds }} is just {{ next_execution_date }} in YYYY-MM-DD format so that we don't need to write something like {{ ds_format(next_execution_date, "%Y-%m-%d")}}
Thus I think we should make sure that the behavior of {{ next_ds }} aligns with
{{ next_execution_date }}.
So I think we should do either:
option 1:
If {{ next_execution_date }} is None, we set {{ next_ds }} to None.
option 2:
We make sure {{ next_execution_date }} is never None. But this will change the fact that
{{ next_execution_date }} is None when schedule_interval="@once".
There was a problem hiding this comment.
cool, Default with none is ok in this case.
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
+ Coverage 76.5% 76.51% +<.01%
==========================================
Files 203 203
Lines 15025 15031 +6
==========================================
+ Hits 11495 11501 +6
Misses 3530 3530
Continue to review full report at Codecov.
|
Closes apache#3418 from milton0825/introduce-next_ds- prev_ds
Closes apache#3418 from milton0825/introduce-next_ds- prev_ds
4 participants
Make sure you have checked all steps below.
JIRA
Description
Introduce two new macros:
{{ prev_ds }}: the previous execution date as {{ YYYY-MM-DD }}
{{ next_ds }}: the next execution date as {{ YYYY-MM-DD }}
Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff