@alexbegg thanks for contribution to Pinot Provider. Could you also add missing class attributes to PinotDbApiHook and PinotAdminHook

• conn_name_attr: name of attribute which use for connection_id
• default_conn_name: default connection_id
• conn_type: type of connection from provider.yaml
• hook_name: Name in Connection dropdown list

Examples:

I have added those missing args, however I noticed some oddities with this provider:

• The example DAG is seeming to confuse the use of an Operator and of a Hook. If you see in this example, a task_id is defined for a hook, which is not correct (this argument will just be ignored). The hook's params are used almost as if they were operator params...

  airflow/tests/system/providers/apache/pinot/example_pinot_dag.py

  Lines 42 to 48 in 487b174

  	@task
  	def pinot_dbi_api():
  	PinotDbApiHook(
  	task_id="run_example_pinot_script",
  	pinot="ls /;",
  	pinot_options="-x local",
  	)

• The "Operators" documentation page for the provider, https://airflow.apache.org/docs/apache-airflow-providers-apache-pinot/stable/operators.html, shows how to use the hooks in TaskFlow-decorated task functions, instead of actual operators as the page name would suggest.
• In the above example code, initializing the hook class is used to execute a command, however shouldn't the hook just be used to initialize the class and then methods of that hook are used to execute commands? If that is done then we can even add in operators that make use of that hook's method.

Should this provider get actual operators, to avoid this confusion?

Should this provider get actual operators, to avoid this confusion?

The DBAPI- derived Hooks in provider are used by SQL*Operator family from Common SQL - that's why there is no "PinotSQL" operator - you just use common.sql SQL* operators and specify Pinot connection, the Hook is then created automatically and used by them

Maybe worth-while if someone (You ?) can make it clearer in the documentation if it is not clear enough.

I am not a regular user of Pinot so I am probably not the best to improve documentation for it. I attempted, but then stopped because of my unfamiliarity. I believe if the main point of this PR is to fix this bug then it will be good to go as is.