Skip to content

Improve graph nesting logic#33421

Merged
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:fix-group-edge-labels
Aug 16, 2023
Merged

Improve graph nesting logic#33421
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:fix-group-edge-labels

Conversation

@bbovenzi

@bbovenzi bbovenzi commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Fix how we handle nested groups to make sure edge labels inside of groups are correctly positions and that nested nodes with the same label don't mess with rendering.

Before After
Screenshot 2023-08-15 at 4 30 24 PM Screenshot 2023-08-15 at 4 05 16 PM
Screenshot 2023-08-15 at 4 30 18 PM Screenshot 2023-08-15 at 4 05 00 PM

Aug-15-2023 11-47-38


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.7.0 milestone Aug 15, 2023
@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 15, 2023
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 16, 2023
@ephraimbuddy
ephraimbuddy merged commit 6547b81 into apache:main Aug 16, 2023
@ephraimbuddy
ephraimbuddy deleted the fix-group-edge-labels branch August 16, 2023 04:38
ephraimbuddy pushed a commit that referenced this pull request Aug 16, 2023
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants