Fix eager upgrade failures for canary builds#33395
Merged
Merged
Conversation
The canary builds continued failing after fixing aibotocore in #33364 when aiobotocore dependency limit dependency limit. This was because the main build is now using "empty" eager upgrade requirements which override the embedded aiobotocore and continue trigger backtracking. This is not easily visible on CI because the backtracking error is under a folded CI image build group in CI. This PR fixes both: * only overrides eager requirements if they are not empty * make sure that eager upgrade output is in the unfolded output of CI job
potiuk
force-pushed
the
fix-eager-upgrade-ci-failures
branch
from
August 14, 2023 19:58
c51cde0 to
63dbe54
Compare
eladkal
approved these changes
Aug 14, 2023
hussein-awala
approved these changes
Aug 14, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2023
The canary builds continued failing after fixing aibotocore in #33364 when aiobotocore dependency limit dependency limit. This was because the main build is now using "empty" eager upgrade requirements which override the embedded aiobotocore and continue trigger backtracking. This is not easily visible on CI because the backtracking error is under a folded CI image build group in CI. This PR fixes both: * only overrides eager requirements if they are not empty * make sure that eager upgrade output is in the unfolded output of CI job (cherry picked from commit 3857d33)
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
The canary builds continued failing after fixing aibotocore in apache#33364 when aiobotocore dependency limit dependency limit. This was because the main build is now using "empty" eager upgrade requirements which override the embedded aiobotocore and continue trigger backtracking. This is not easily visible on CI because the backtracking error is under a folded CI image build group in CI. This PR fixes both: * only overrides eager requirements if they are not empty * make sure that eager upgrade output is in the unfolded output of CI job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary builds continued failing after fixing aibotocore
in #33364 when aiobotocore dependency limit dependency limit. This was
because the main build is now using "empty" eager upgrade requirements
which override the embedded aiobotocore and continue trigger
backtracking.
This is not easily visible on CI because the backtracking
error is under a folded CI image build group in CI.
This PR fixes both:
of CI job
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.